FR - CMS chapter

[JustinyAhin]

Makes progress on #539

I've finally ended up the chapter. It was difficult with many of technical expressions not having an easy or obvious translation in FR. I'd be happy to get a quick review on the PR.

[tunetheweb]

Thanks! Yeah can imagine it's tough to do these translations.

A few technical nits with the meta data for you to correct.

Also is it possible for you to run npm run generate from the src directory to generate the HTML version as well? If not familiar with npm then let us know and can do that later.

@borisschapira , @nico3333fr , @allemas , @AymenLoukil , @SilentJMA would be great to have one of you check the translation before we merge if you can.

[borisschapira]

Excellent work, if you ask. The result is fluid, while using a sustained vocabulary. It's very good work, and given the length of the document, it must have taken a while. Thank you very much for that.

I corrected a few minor typos that needed a little rework, and a small issue regarding markdown links (you need to remove spaces between "]" and "("), but that's nearly nothing.

[borisschapira]

I've clicked on "Approve" by error (damn interactive elements that moves while the component's loading). While I approve the translations, there are small fixes to be made.

[JustinyAhin]

Thank you @borisschapira for reviewing.
And @bazzadp for the flags you raised. I'll integrate them soon.

[JustinyAhin]

Also is it possible for you to run npm run generate from the src directory to generate the HTML version as well? If not familiar with npm then let us know and can do that later.

Hey @bazzadp. I run npm run generate and it looks to throw an error. Here's the output

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! almanac.httparchive.org@0.0.1 generate: `node ./tools/generate`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the almanac.httparchive.org@0.0.1 generate script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

So I run npm install and npm run generate again but I don't file it generates any new file. Can you look at this please?

Also, I've accepted your others suggestions.

[JustinyAhin]

@borisschapira all the changes and typos corrections are integrated :)

[borisschapira]

LGTM

[tunetheweb]

So I run npm install and npm run generate again but I don't file it generates any new file. Can you look at this please?

Interesting. It would be good to get this sorted for you.

Questions from me:

• Did npm install run correctly and create stuff in your src/node_modules directory?
• Any output or error messages from npm install?
• Any output or error messages from npm run generate or did it run cleanly this time?
• Did npm run generate look like it was iterating through the chapters?
• What version of node are you running?

[JustinyAhin]

• Did npm install run correctly and create stuff in your src/node_modules directory?

Yes, here's npm install output:

added 160 packages from 152 contributors and audited 210 packages in 72.774s
found 2 low severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details

• Any output or error messages from npm install?

No

• Any output or error messages from npm run generate or did it run cleanly this time?

I've got just warnings, not errors

almanac.httparchive.org@0.0.1 generate C:\Users\EubertineAhinon\Desktop\almanac.httparchive.org\src
node ./tools/generate
(node:7300) UnhandledPromiseRejectionWarning: TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
    at generate_chapters (C:\Users\Eubertine Ahinon\Desktop\almanac.httparchive.org\src\tools\generate\generate_chapters.js:27:45)
    at async C:\Users\Eubertine Ahinon\Desktop\almanac.httparchive.org\src\tools\generate\index.js:9:3
(node:7300) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:7300) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.`

• Did npm run generate look like it was iterating through the chapters?

No, just run at once

• What version of node are you running?

node 12.14.1 and npm 6.13.4

[tunetheweb]

Ah this is because us selfish Mac users never set this up to work properly for windows.

If you temporarily change line 26 of src\tools\generate_chapter.js to the following:

    const re = /content\/(.*)\/(.*)\/(.*).md/;

to the following

    const re = /content\\(.*)\\(.*)\\(.*).md/;

Then it will work.

Can you try that and then add the HTML to this PR (but do not commit the change to generate_chapter.js - as don't want to break it for the rest of us).

Raised #622 to see if we can fix this properly.

[mikegeyser]

guiltily puts hand up as selfish mac user

Sorry, will fix it!

[tunetheweb]

@JustinyAhin , @mikegeyser has now fixed this permenately in 8693c9c and I've merged that in, so if you merge in from upstream master it should work for you now.

Thanks @mikegeyser !

[JustinyAhin]

hey @bazzadp just run npm run generate successfully. some files as markup.html were regenarated, and I commit them. you can look at the commits messages.

[tunetheweb]

Looks good and merged to master now. Thanks for translating this chaper and hopefully next one will be easier!

Happy with those extra commits too - sometimes we miss things for chapters in flights (like for example if you hadn't been able to generate the HTML for your translation) and the next generate picks them up. So thanks for that 😊

[JustinyAhin]

Cool,
I really loved translating the chapter. Thanks to all for your help. It doesn't look like there is a translation to review in the queue. So I'll jump on another chapter.

[tunetheweb]

Thanks! Go for it.