Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misc errors and inconsistencies #644

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Fix misc errors and inconsistencies #644

merged 1 commit into from
Jan 18, 2020

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Jan 18, 2020 •
edited
Loading

Fixes the following highlighted by Lighthouse:

  • Twitter and Github image heights and width were transposed
  • Typo in button aria attribute (arial-label instead of aria-label)
  • Console error as CSP doesn't allow www.google.com - made this more generic as Google keeps adding things.

Also fixed these at same time:

  • Contributors Twitter and Github links were Github and Twitter when it's the other way around for everything else
  • CDN markdown as a line break mid-paragraph as notice here

@tunetheweb tunetheweb added bug Something isn't working development Building the Almanac tech stack labels Jan 18, 2020
@tunetheweb tunetheweb mentioned this pull request Jan 18, 2020
Merged
@rviscomi rviscomi merged commit 509e4bd into master Jan 18, 2020
@rviscomi rviscomi deleted the fix_lighthouse_bugs branch January 18, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working development Building the Almanac tech stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tunetheweb @rviscomi