FR - Translation "Resource Hints" Chapter #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
requested changes
Jan 30, 2020
There was a problem hiding this comment.
Thansk @borisschapira - spotted a few things for you to look at.
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
|
Thanks a lot @bazzadp. As always, you provide great feedback. |
tunetheweb
approved these changes
Jan 30, 2020
tunetheweb
requested changes
Jan 30, 2020
nico3333fr
reviewed
Jan 30, 2020
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
I've fixed a lot of issues (thanks!) and tried to answer everything else. For some question, I know there is not "good" answer so tell us if the answer I provided looks good, or if you think we need a second (or third) opinion. |
tunetheweb
approved these changes
Jan 30, 2020
nico3333fr
reviewed
Jan 30, 2020
|
@bazzadp I'm always happy :) (except when I'm sad, for sure) To be serious, this is ok for me :) Good job guys 👍 |
|
Thanks both! Merging away... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #539