Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Mohammad-Darwesh homework js2 week2 #299

Conversation

mohammadnaefaldarwesh
Copy link

No description provided.

Copy link

@paulbremer paulbremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mohammad! Good job, the code looks very nice but try step 2 from the homework again. If you edit the files in the homework folder the test will run, and should pass as well.

@@ -0,0 +1,70 @@
'use strict';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to test your homework using npm run test-week2? The test is looking at the files in the homework folder, so instead of putting new files in a new folder you should edit the files there.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Paulbremer,
Thank you for your feedback .
I did just what you tell me and it pass the test just as you said .
There is some changing in json files ....i realy do know why but i did push anyway.
thanks,

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @mohammadnaefaldarwesh the tests are passing fine now! 👌

}
// eslint-disable-next-line no-unused-vars
const earnings = computeEarnings(maartjesTasks, maartjesHourlyRate);
earnings.toFixed(2);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you are using the NumberFormat this line does nothing. I like that you are using a new function (Intl.NumberFormat), but in this case toFixed(2) will result in the same output.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants