Datepicker and Calendar are injectable for locale changes #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! This looks great, I'll see if I can get to reviewing this tomorrow, thanks for taking the time to write this PR! |
|
Thanks again for this PR, there were some merge conflicts in the compiled files (sigh), so I merged it manually. Let me know if I missed anything in the merge! I'll also see to adding a localized example to the examples (and maybe see to finally adding github pages for the examples). |
|
Thanks for merging my changes. You could have just merge src files and build it again - by this you would avoid conflicts. |
|
Version 0.8 just got release by @martijnrusschen ! |
|
Great :) thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to change locale for datepicker (and callendar).
All locale variables are injectable to datepicker component, now I can send it what to show (including moment itself, so it can have defined locale of my own).
PS: I'm not sure about compiled files - i just builded it with "grunt build" command