Replace onClick with onMouseDown #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Down onMouseDown is actually triggered *before* blur in at least Firefox and Chrome. IE test is still needed.
There was a problem hiding this comment.
Found this suggestion at http://facebook.github.io/react/tips/communicate-between-components.html and I liked it! It seems similar to the following Coffeescript we use at HackerOne:
handleClick: (item) -> =>
@setState clicked: item
render: ->
div onClick: @handleClick(item)What do you guys think?
I can confirm that this behaves as expected in IE. Cool! |
martijnrusschen
pushed a commit
that referenced
this pull request
Jul 8, 2014
Replace onClick with onMouseDown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onMouseDown is actually triggered before blur in at least Firefox and Chrome. IE test is still needed.
This way we no longer need the ugly and flaky setTimeout (only one left to defer the focus for Firefox).
Fixes #28