-
Notifications
You must be signed in to change notification settings - Fork 23
Added article section with updated card component layout using tailwind css #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Heykcer is attempting to deploy a commit to the notshrirang's projects Team on Vercel. A member of the Team first needs to authorize it. |
@NotShrirang Please review |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Hey, great progress! Just a few things before we merge:
- Avoid hardcoding values directly in the component file. Let's make them props.
- The Card component should accept props like "title", "description", "author", and "date" for better reusability.
- Instead of embedding the Card component directly, consider creating an
ArticleSuggestion
component that maps over the articles array and displays the cards in a row on the landing page.
I have added comments. Once these changes are made, it should be good to go. Let me know if you need any clarification!"
@NotShrirang review the changes |
Summary
This PR introduces a new
article-section
folder containing a reusable ArticleCard component for displaying articles to users.Changes
Purpose
The Card component will be used to display articles in a visually appealing card format whenever users visit the site. This helps improve UI consistency and user experience.
Issue
Fixes #20
Notes