Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VK_KHR_dynamic_rendering #905

Merged

Conversation

doitsujin
Copy link
Collaborator

@doitsujin doitsujin commented Nov 16, 2021

Keeping this as a draft for now since merging without support from stable drivers is not an option.

Tests pass on Nvidia, requires Vulkan beta driver 470.62.12 or later.

Needs more testing on RADV as its implementation of the extension comes along, and testing in actual games, although for that we'll need some sort of working Proton build with winevulkan support for this extension. I haven't checked if this is provided by proton-experimental bleeding edge yet.

@doitsujin doitsujin marked this pull request as draft November 16, 2021 14:45
@doitsujin doitsujin force-pushed the dynamic-rendering branch 3 times, most recently from 7dd60a7 to 43317be Compare January 21, 2022 12:38
@doitsujin doitsujin force-pushed the dynamic-rendering branch 2 times, most recently from cabfbfe to ae89a77 Compare February 4, 2022 15:47
@doitsujin doitsujin force-pushed the dynamic-rendering branch 2 times, most recently from b95175e to ef899a7 Compare February 4, 2022 17:49
Copy link
Owner

@HansKristian-Work HansKristian-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we can land this when we decide to.

@hurricane-dorian
Copy link

Since branch update 8a7bfd6 all games just black-screen then crash.
Mesa-git on rx5700 amdgpu 5.16.9

@doitsujin
Copy link
Collaborator Author

doitsujin commented Feb 16, 2022

Yes, this is a known issue with the current rebase since this breaks the pipeline feedback stuff that was added recently.

@HansKristian-Work
Copy link
Owner

Found one bug for reference, caught by #1027:

    if (d3d12_command_list_has_depth_stencil_view(list))
    {
        /* Select new dsv_layout. Any new PSO write we didn't observe yet must be updated here. */
        dsv_plane_optimal_mask = list->dsv_plane_optimal_mask | list->state->graphics.dsv_plane_optimal_mask;
        dsv_layout = dsv_plane_optimal_mask_to_layout(list->dsv_plane_optimal_mask, // Should be dsv_plane_optimal_mask
                list->dsv.format->vk_aspect_mask);
    }
    else
    {
        dsv_plane_optimal_mask = 0;
        dsv_layout = VK_IMAGE_LAYOUT_UNDEFINED;
    }

Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
@doitsujin doitsujin force-pushed the dynamic-rendering branch from 0a8511e to 09cf9e1 Compare March 8, 2022 15:51
@doitsujin doitsujin marked this pull request as ready for review March 8, 2022 15:51
These only existed for VRS attachment, which is no longer
necessary with VK_KHR_dynamic_rendering.

Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
@doitsujin doitsujin force-pushed the dynamic-rendering branch from 09cf9e1 to 0574792 Compare March 8, 2022 16:15
@HansKristian-Work HansKristian-Work merged commit 9a40836 into HansKristian-Work:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants