-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use VK_KHR_dynamic_rendering #905
Use VK_KHR_dynamic_rendering #905
Conversation
e4ecb1d
to
05f5421
Compare
7dd60a7
to
43317be
Compare
43317be
to
8a7bfd6
Compare
cabfbfe
to
ae89a77
Compare
ae89a77
to
d57c031
Compare
b95175e
to
ef899a7
Compare
ef899a7
to
0a8511e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we can land this when we decide to.
Since branch update 8a7bfd6 all games just black-screen then crash. |
Yes, this is a known issue with the current rebase since this breaks the pipeline feedback stuff that was added recently. |
Found one bug for reference, caught by #1027:
|
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
0a8511e
to
09cf9e1
Compare
These only existed for VRS attachment, which is no longer necessary with VK_KHR_dynamic_rendering. Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
09cf9e1
to
0574792
Compare
Keeping this as a draft for now since merging without support from stable drivers is not an option.
Tests pass on Nvidia, requires Vulkan beta driver 470.62.12 or later.
Needs more testing on RADV as its implementation of the extension comes along, and testing in actual games, although for that we'll need some sort of working Proton build with winevulkan support for this extension. I haven't checked if this is provided by proton-experimental bleeding edge yet.