Audio Editor Lock Button and Cleanup #3140
Conversation
Added the locked/unlocked button.
…, individual shuffle buttons bypass and the lock and unlock the sound. Added tooltips to all the FA buttons. Shrunk right side of Audio Editor window to match width of new buttons. Unified all references to the randomized value and lock to two functions that automatically applied prefix and suffix. Changed "Reset All" to clear the cvars instead of changing them to default.
|
The one problem I couldn't figure out a solution for was the fact that using the "Reset All" or "Randomize All" buttons still restarted the currently playing background music, even if you had that locked, as well as the (I believe) already existing issue of an individual Randomize button on the active scene's BGM not changing the BGM currently playing. |
There was a problem hiding this comment.
using the "Reset All" or "Randomize All" buttons still restarted the currently playing background music, even if you had that locked,
This seems very minor, and unsurprising, fine for now
as well as the (I believe) already existing issue of an individual Randomize button on the active scene's BGM not changing the BGM currently playing.
This one sounds a bit worse, and undesirable. Could you confirm this is an existing issue? Approving with the assumption that it is, and wasn’t introduced with these changes.
|
Yeah, just confirmed with a release build. The reason is because |
if doing it separate will cause conflicts just throw it in this one |
…randomizing current sequence.
…nt for lock button blocking changes.
…into audio-editor-lock
|
Well, nevermind. Not only was the problem with the randomize button an extremely simple fix (simpler than I originally thought), it was actually pretty easy to put in the check for currently playing BGM having not changed during a Reset All or Randomize All to block the restart of the sequence. So everything should be good to go now. |
aMannus
added
the
blocking
Adds a lock button to the audio editor to prevent "Randomize All" buttons from changing specific sounds.
Cleaned up the UI a bit with FontAwesome buttons instead of text buttons, and added tooltips for clarification.
Set all resets (individual reset buttons and "Reset All") to clear CVars instead of setting the value to default (settings .json cleanup).
https://youtu.be/_tRr-0-qeyI
Build Artifacts