fix(post-details) : Inconsistency in GraphQL Query for Author Data #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cleancodecraft , Hello ! what do you think about the commit & pull request titles , should I adjust something ? thank you ! |
esteecodes
changed the title
esteecodes
approved these changes
May 22, 2024
There was a problem hiding this comment.
@MestiriBaha everything looks great
thank you for your contribution 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Closes Issue
closes #74
Description
I have made the necessary adjustments to correct the GraphQL query that retrieves author data from Hashnode's API. The changes are as follows:
- In
graphql.operations.ts: Added username and id to the queries that contain author.- In
posts.ts: Added username and included id and username properties in the Author interface.- In post-details: Changed
post.author.nametopost.author.username.What type of PR is this? (check all applicable)
Mobile & Desktop Screenshots/Recordings
[Attach screenshots or recordings if applicable]
Steps to QA
Added to documentation?
[Optional] Post-deployment tasks
[Specify any post-deployment tasks that need to be performed]
[Optional] What gif best describes this PR or how it makes you feel?
[Embed gif or describe the feeling in plain text]