-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sync-v2): implement AsyncP2PStorage [part 10/12] #1025
Open
glevco
wants to merge
1
commit into
refactor/sync-v2/p2p-storage-9
Choose a base branch
from
feat/sync-v2/async-p2p-storage-10
base: refactor/sync-v2/p2p-storage-9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(sync-v2): implement AsyncP2PStorage [part 10/12] #1025
glevco
wants to merge
1
commit into
refactor/sync-v2/p2p-storage-9
from
feat/sync-v2/async-p2p-storage-10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
6 times, most recently
from
May 6, 2024 22:56
f7320f4
to
1bc8d5d
Compare
glevco
changed the title
wip [part 10]
feat(sync-v2): implement AsyncP2PStorage [part 10]
May 6, 2024
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
May 6, 2024 23:16
1bc8d5d
to
812e09e
Compare
glevco
force-pushed
the
refactor/sync-v2/p2p-storage-9
branch
from
May 7, 2024 02:36
c35d431
to
98c0ab6
Compare
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
May 7, 2024 02:37
812e09e
to
14667af
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/sync-v2/p2p-storage-9 #1025 +/- ##
==================================================================
- Coverage 84.91% 84.35% -0.56%
==================================================================
Files 297 304 +7
Lines 22910 23347 +437
Branches 3464 3548 +84
==================================================================
+ Hits 19453 19695 +242
- Misses 2771 2968 +197
+ Partials 686 684 -2 ☔ View full report in Codecov by Sentry. |
This was referenced May 7, 2024
Closed
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
May 7, 2024 21:55
14667af
to
105d406
Compare
glevco
force-pushed
the
refactor/sync-v2/p2p-storage-9
branch
2 times, most recently
from
May 8, 2024 03:12
98c0ab6
to
197c056
Compare
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
May 8, 2024 03:14
105d406
to
6cffd6c
Compare
glevco
force-pushed
the
refactor/sync-v2/p2p-storage-9
branch
3 times, most recently
from
May 10, 2024 02:34
2c96d59
to
380b917
Compare
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
May 10, 2024 02:38
6cffd6c
to
f6300f8
Compare
glevco
force-pushed
the
refactor/sync-v2/p2p-storage-9
branch
from
May 10, 2024 02:53
380b917
to
df7d74e
Compare
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
May 10, 2024 02:54
f6300f8
to
54f16ea
Compare
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
May 13, 2024 03:38
54f16ea
to
a04a822
Compare
glevco
force-pushed
the
refactor/sync-v2/p2p-storage-9
branch
from
May 13, 2024 14:32
df7d74e
to
bfc28b4
Compare
glevco
changed the title
feat(sync-v2): implement AsyncP2PStorage [part 10]
feat(sync-v2): implement AsyncP2PStorage [part 10/12]
May 13, 2024
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
May 13, 2024 14:33
a04a822
to
2ffad4a
Compare
glevco
force-pushed
the
refactor/sync-v2/p2p-storage-9
branch
from
August 23, 2024 22:21
bfc28b4
to
0f41024
Compare
glevco
force-pushed
the
refactor/sync-v2/p2p-storage-9
branch
2 times, most recently
from
August 26, 2024 17:31
ee62d62
to
8aa59d5
Compare
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
August 26, 2024 17:41
2ffad4a
to
b88e78a
Compare
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
August 26, 2024 17:42
b88e78a
to
5bac927
Compare
glevco
force-pushed
the
refactor/sync-v2/p2p-storage-9
branch
from
September 18, 2024 18:07
8aa59d5
to
2fda7b7
Compare
glevco
force-pushed
the
feat/sync-v2/async-p2p-storage-10
branch
from
September 18, 2024 18:07
5bac927
to
d61fd76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1024
Motivation
This PR continues the implementation started in the previous PR, #1024. Read its description for more info. It implements an async version for the new Sync-v2 abstractions, and adds a CLI option to enable it. Currently, tests do not run using the async version, this will be implemented in a future PR.
Acceptance Criteria
--x-use-async-sync-v2
CLI option.AsyncP2PStorage
andAsyncP2PVertexHandler
classes.SyncV2Factory
to support async Sync-v2.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged