Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync-v2): implement AsyncP2PStorage [part 10/12] #1025

Open
wants to merge 1 commit into
base: refactor/sync-v2/p2p-storage-9
Choose a base branch
from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented May 6, 2024

Depends on #1024


Motivation

This PR continues the implementation started in the previous PR, #1024. Read its description for more info. It implements an async version for the new Sync-v2 abstractions, and adds a CLI option to enable it. Currently, tests do not run using the async version, this will be implemented in a future PR.

Acceptance Criteria

  • Add unsafe --x-use-async-sync-v2 CLI option.
  • Implement AsyncP2PStorage and AsyncP2PVertexHandler classes.
  • Update SyncV2Factory to support async Sync-v2.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this May 6, 2024
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch 6 times, most recently from f7320f4 to 1bc8d5d Compare May 6, 2024 22:56
@glevco glevco changed the title wip [part 10] feat(sync-v2): implement AsyncP2PStorage [part 10] May 6, 2024
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from 1bc8d5d to 812e09e Compare May 6, 2024 23:16
@glevco glevco force-pushed the refactor/sync-v2/p2p-storage-9 branch from c35d431 to 98c0ab6 Compare May 7, 2024 02:36
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from 812e09e to 14667af Compare May 7, 2024 02:37
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 81.16505% with 194 lines in your changes missing coverage. Please review.

Project coverage is 84.35%. Comparing base (de9ea6d) to head (2ffad4a).
Report is 124 commits behind head on refactor/sync-v2/p2p-storage-9.

Files Patch % Lines
hathor/p2p/sync_v2/p2p_storage.py 49.65% 73 Missing ⚠️
hathor/p2p/sync_v2/p2p_vertex_handler.py 46.55% 31 Missing ⚠️
...tion/storage/migrations/migrate_static_metadata.py 41.66% 21 Missing ⚠️
hathor/vertex_handler/vertex_handler.py 59.45% 14 Missing and 1 partial ⚠️
...ction/storage/migrations/migrate_feature_states.py 52.00% 12 Missing ⚠️
hathor/p2p/sync_v2/blockchain_streaming_client.py 60.00% 4 Missing ⚠️
hathor/transaction/storage/rocksdb_storage.py 82.60% 4 Missing ⚠️
hathor/transaction/storage/transaction_storage.py 90.47% 2 Missing and 2 partials ⚠️
hathor/verification/transaction_verifier.py 77.77% 1 Missing and 3 partials ⚠️
hathor/verification/verification_service.py 93.75% 2 Missing and 2 partials ⚠️
... and 12 more
Additional details and impacted files
@@                        Coverage Diff                         @@
##           refactor/sync-v2/p2p-storage-9    #1025      +/-   ##
==================================================================
- Coverage                           84.91%   84.35%   -0.56%     
==================================================================
  Files                                 297      304       +7     
  Lines                               22910    23347     +437     
  Branches                             3464     3548      +84     
==================================================================
+ Hits                                19453    19695     +242     
- Misses                               2771     2968     +197     
+ Partials                              686      684       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review May 7, 2024 15:23
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from 14667af to 105d406 Compare May 7, 2024 21:55
@glevco glevco force-pushed the refactor/sync-v2/p2p-storage-9 branch 2 times, most recently from 98c0ab6 to 197c056 Compare May 8, 2024 03:12
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from 105d406 to 6cffd6c Compare May 8, 2024 03:14
@glevco glevco force-pushed the refactor/sync-v2/p2p-storage-9 branch 3 times, most recently from 2c96d59 to 380b917 Compare May 10, 2024 02:34
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from 6cffd6c to f6300f8 Compare May 10, 2024 02:38
@glevco glevco force-pushed the refactor/sync-v2/p2p-storage-9 branch from 380b917 to df7d74e Compare May 10, 2024 02:53
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from f6300f8 to 54f16ea Compare May 10, 2024 02:54
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from 54f16ea to a04a822 Compare May 13, 2024 03:38
@glevco glevco force-pushed the refactor/sync-v2/p2p-storage-9 branch from df7d74e to bfc28b4 Compare May 13, 2024 14:32
@glevco glevco changed the title feat(sync-v2): implement AsyncP2PStorage [part 10] feat(sync-v2): implement AsyncP2PStorage [part 10/12] May 13, 2024
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from a04a822 to 2ffad4a Compare May 13, 2024 14:33
@glevco glevco force-pushed the refactor/sync-v2/p2p-storage-9 branch from bfc28b4 to 0f41024 Compare August 23, 2024 22:21
@glevco glevco force-pushed the refactor/sync-v2/p2p-storage-9 branch 2 times, most recently from ee62d62 to 8aa59d5 Compare August 26, 2024 17:31
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from 2ffad4a to b88e78a Compare August 26, 2024 17:41
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from b88e78a to 5bac927 Compare August 26, 2024 17:42
@glevco glevco force-pushed the refactor/sync-v2/p2p-storage-9 branch from 8aa59d5 to 2fda7b7 Compare September 18, 2024 18:07
@glevco glevco force-pushed the feat/sync-v2/async-p2p-storage-10 branch from 5bac927 to d61fd76 Compare September 18, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant