Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlxNape: got SolarSystem demo back in action #152

Merged
merged 1 commit into from
Sep 24, 2014
Merged

FlxNape: got SolarSystem demo back in action #152

merged 1 commit into from
Sep 24, 2014

Conversation

D-side
Copy link
Contributor

@D-side D-side commented Sep 24, 2014

FlxNape

Minor changes to get SolarSystem demo back.

  • Number of states in demo extracted into a constant statesNumber for convenient changes in the future
  • Prettier prevDemo function in Main and overall refactoring to use statesNumber
  • Some changes in SolarSystem class to make it work with the new structure
    • inheritance from FlxNapeState changed to BaseState
    • no key check for G, R and arrow keys: done in BaseState anyway
    • halfWidth and halfHeight are now filled on state's create: otherwise stay at 0

Changes are minor, not feeling any platform-specific quirks in effect here. Tested out on Linux/C++ target and Flash, works fine.

My first pull request ever. Might have screwed up somewhere =)

@D-side
Copy link
Contributor Author

D-side commented Sep 24, 2014

For some reason, crashes on launch on Neko. Before and after the change. Investigating.

@Gama11
Copy link
Member

Gama11 commented Sep 24, 2014

Nice! I think this part of the demo was never entirely finished, and thus not used (it's missing graphics, but the phyiscs work well enough without that). Might be able to find something suitable on http://opengameart.org/ or similar...

About neko, don't worry about it. It's been discussed here. It's probably some crazy neko bug.

My first pull request ever. Might have screwed up somewhere =)

Nope, everything's perfect. :)

Gama11 added a commit that referenced this pull request Sep 24, 2014
FlxNape: got SolarSystem demo back in action
@Gama11 Gama11 merged commit 15b8f87 into HaxeFlixel:dev Sep 24, 2014
@gamedevsam
Copy link
Contributor

Congrats D-side! If you keep it up we'll make you part of the team 👍

@D-side D-side deleted the nape-solarsystem branch September 25, 2014 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants