Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Turkish Translations #2830

Merged
merged 12 commits into from
Jun 5, 2023
Merged

Add Turkish Translations #2830

merged 12 commits into from
Jun 5, 2023

Conversation

neondev27
Copy link
Contributor

Added path to Turkish translation

@Geokureli
Copy link
Member

Geokureli commented Jun 2, 2023 •
edited
Loading

This is awesome!

Instead of linking to an external fork we should add README_TR.md and CONTRIBUTING_TR.md to the main flixel repo and link to those pages in the english versions. I'm also not sure that we should translate the license unless it can be verified by a real lawyer who speaks Turkish, also I assume MIT License is universally understood

@Geokureli Geokureli mentioned this pull request Jun 2, 2023
Closed
@Geokureli Geokureli changed the title Update README.md Add Turkish Translations Jun 2, 2023
@neondev27
Copy link
Contributor Author

That means i need to repull request with your suggestions?

@neondev27
Copy link
Contributor Author

I did changes you said @Geokureli.

Geokureli
Geokureli requested changes Jun 2, 2023
View reviewed changes
Copy link
Member

@Geokureli Geokureli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. some formatting issues
  2. link to haxeflixel pages
  3. move CONTRIBUTING_TR.md to .github/
  4. I think CONTRIBUTING.md should have a link to turkish and CONTRIBUTING_TR.md should have a link to english as well

CONTRIBUTING_TR.md Outdated Show resolved Hide resolved
CONTRIBUTING_TR.md Outdated Show resolved Hide resolved
README_TR.md Outdated Show resolved Hide resolved
README_TR.md Outdated Show resolved Hide resolved
README_TR.md Outdated Show resolved Hide resolved
README_TR.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
neondev27 and others added 8 commits June 3, 2023 07:20
@neondev27 @Geokureli
Update CONTRIBUTING_TR.md
3bbb966 
Co-authored-by: George Kurelic <Gkurelic@gmail.com>
@neondev27 @Geokureli
Update README_TR.md
d996615 
Co-authored-by: George Kurelic <Gkurelic@gmail.com>
@neondev27 @Geokureli
Update README_TR.md
206ce80 
Co-authored-by: George Kurelic <Gkurelic@gmail.com>
@neondev27 @Geokureli
Update README.md
af7e59b 
Co-authored-by: George Kurelic <Gkurelic@gmail.com>
@neondev27 @Geokureli
Update README_TR.md
aca55c7 
Co-authored-by: George Kurelic <Gkurelic@gmail.com>
@neondev27
Rename CONTRIBUTING_TR.md to .github/CONTRIBUTING_TR.md
0838d56
@neondev27
Rename README_TR.md to .github/README_TR.md
0e461a6
@neondev27
Update README.md
0c87cb2
@neondev27
Copy link
Contributor Author

It is final look of the things. I wish it helped, @Geokureli

@neondev27
Copy link
Contributor Author

If anything else needed, call.me from here or @ NeoDev27 in Twitter

@Geokureli Geokureli merged commit 9d1e224 into HaxeFlixel:dev Jun 5, 2023
@Geokureli
Copy link
Member

Thanks!

Geokureli added a commit that referenced this pull request Jun 15, 2023
@Geokureli
add changelog #2789 #2824 #2830 #2832 #2833 #2840 #2841
65db2e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geokureli Geokureli Geokureli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neondev27 @Geokureli