-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[display] @signature completion and unnamed arguments #6064
Comments
I guess I'll work this around by injecting argument names on haxe-languageserver for now. |
I don't think Haxe should invent names here. It's up to the IDE how it wants to display this case. |
In this case I'd argue that the output should be properly structured instead of spitting out weird concatenated strings, which is not much better than we had before format-wise. |
People really shouldn't have to do this: vshaxe/haxe-language-server@942470d#diff-bdfa664c96d8ab764d530048de8ed45dR47 |
What's wrong with |
That works for the parameters, but not the label:
|
Yes I agree that requires more structure. If only we had JSON output for types... |
Haxe returns the following for
@signature
completion for callback types (and thus empty argument names):Not technically wrong, but looks ugly and makes VS Code go crazy:
Before
@signature
was a thing, I solved that by adding generica
,b
,c
,etc. names to unnamed arguments. Maybe we should do the same for@signature
too. Thoughts? @Simn @Gama11The text was updated successfully, but these errors were encountered: