Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code always 0 if compiled with --connect 6000 even if source contains errors #6431

Closed
polygonal opened this issue Jul 3, 2017 · 4 comments

Comments

@polygonal
Copy link
Contributor

Usage:

Main.hx

class Main { }

compile.bat

haxe -main Main --connect 6000
echo %errorlevel%
if errorlevel 1 (
	echo COMPILATION FAILED
)

In this case errorlevel is always 0, but the output is

src/Main.hx:3: lines 3-6 : Invalid -main : Main does not have static function main

Haxe 2017-03-20: 3.4.2

@Simn
Copy link
Member

Simn commented Aug 2, 2017

I cannot seem to reproduce that:

haxe -main Main --connect 6000
Main.hx:1: characters 1-15 : Invalid -main : Main does not have static function main

echo %ERRORLEVEL%
1

@Simn Simn closed this as completed Aug 2, 2017
@Gama11
Copy link
Member

Gama11 commented Mar 29, 2018

This actually reproduces for me on Windows 10 for both Haxe 3.4.7 and latest Haxe dev. This is problematic because it leads to lime test launching the previous build if there were compilation errors, as it checks the exit code via Sys.command().

Could this be reopened?

@ncannasse ncannasse reopened this Mar 30, 2018
@Gama11
Copy link
Member

Gama11 commented Mar 30, 2018

Ok, turns out this was a bug in vshaxe, so this only happened when connecting to a compilation server started by vshaxe. Fixed in vshaxe/haxe-language-server@7e1b03f.

@polygonal may have had the same issue? Anyway, I think this can be closed again, sorry for the false alarm. :)

@polygonal
Copy link
Contributor Author

polygonal commented Mar 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants