Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flash] Failing on glsl2agal.swc #7796

Closed
RealyUniqueName opened this issue Feb 14, 2019 · 11 comments
Closed

[flash] Failing on glsl2agal.swc #7796

RealyUniqueName opened this issue Feb 14, 2019 · 11 comments
Assignees
Labels
platform-flash Everything related to Flash / SWF regression
Milestone

Comments

@RealyUniqueName
Copy link
Member

With the latest Haxe:

class Main {
  static public function main() {}
}
$ haxe -main Main -swf-lib glsl2agal.swc -swf test.swf -swf-lib glsl2agal.swc 
Error: The input swf glsl2agal.swc is corrupted

This is official Adobe's library: https://github.com/adobe/glsl2agal/blob/master/bin/glsl2agal.swc
Works fine with Haxe 3.4.

@RealyUniqueName RealyUniqueName added platform-flash Everything related to Flash / SWF regression labels Feb 14, 2019
@Simn
Copy link
Member

Simn commented Feb 14, 2019

That is likely going to require a bisect. I didn't think we changed anything related to this...

@RealyUniqueName
Copy link
Member Author

Can move this to "Release 4.0" milestone?
This is very bad for the Flash target.

@Simn Simn added this to the Release 4.0 milestone Feb 28, 2019
@Simn
Copy link
Member

Simn commented Feb 28, 2019

I can but this isn't exactly high on my priority list.

@nadako
Copy link
Member

nadako commented Feb 28, 2019

The issue here is that IO.read_bits is bugged in the current extlib version we use. We fixed it in HaxeFoundation/ocamllibs@97ddb4d but then it was unfixed by using extlib from opam. I reported the issue here ygrek/ocaml-extlib#50, but we should think about what can/should we do until the fixed extlib is released. One option of course is to copy extlib back into ocamlllibs again...

@nadako
Copy link
Member

nadako commented Mar 3, 2019

Waiting for the new extlib to be released after ygrek/ocaml-extlib#52 is merged. Then we can pin it and it should be fixed :-3

nadako added a commit to nadako/haxe that referenced this issue Mar 3, 2019
@Simn
Copy link
Member

Simn commented Mar 12, 2019

Can we close this?

@nadako
Copy link
Member

nadako commented Mar 12, 2019

Not yet, I have to figure out how to actually pin the dependency now.

@nadako
Copy link
Member

nadako commented Mar 12, 2019

(i have a branch)

@Simn
Copy link
Member

Simn commented Mar 12, 2019

Why do we have to pin something though? We should only need pinning if we want to rely on an older version of a lib.

@nadako
Copy link
Member

nadako commented Mar 12, 2019

Well, it's not exactly "pinning", it's >= "1.7.6" to make sure we're using the fixed version.

@nadako
Copy link
Member

nadako commented Mar 12, 2019

The problem is that it currently says - No package matches extlib>=1.7.6., even though it's there (https://opam.ocaml.org/packages/extlib/) and I didn't have a change to investigate the reson.

nadako added a commit that referenced this issue Mar 20, 2019
andyli pushed a commit that referenced this issue Mar 21, 2019
nadako added a commit that referenced this issue Mar 21, 2019
@nadako nadako closed this as completed in cc693c5 Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-flash Everything related to Flash / SWF regression
Projects
None yet
Development

No branches or pull requests

3 participants