Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eval] Rework capture variable handling #8017

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

Simn
Copy link
Member

@Simn Simn commented Mar 19, 2019

I know I know, another typical Haxe-rc change. But I have to do it.

Here's the good news from the benchmarks:

what before after change
static closure 3,937,595 4,128,581 +5%
field closure 3,352,771 3,492,588 +4%
local closure 2,595,895 3,172,965 +22%
local function 2,496,921 4,080,627 +63%

In particular, local functions that don't capture anything are now treated just like normal static functions, giving them a huge speedup.

closes #7983

@Simn Simn merged commit 4d426db into HaxeFoundation:development Mar 19, 2019
@Simn Simn deleted the eval_closure_rework branch March 19, 2019 18:25
@skial skial mentioned this pull request Mar 20, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[eval] Improve capture variable handling
1 participant