parse expr is typepath
outside parenthesis
#9672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the usages of
expr_next
and looks like we're good to lose parenthesis aroundexpr is Type
.The error message is quite cryptic in these cases currently:
because it parses
is
as a normal identifier and then becomes confused aboutBad
going right after it.TODO:
ComplexType
instead of justTypePath
, error on non-typepaths later on typing?EIs
,EBinop
withECheckType
?)@meta a is B
should be like@meta a + b
?)a !is B
to avoid awkward parens for negation?