Make sys_read_dir errors consistent between platforms #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
added a commit
to soccertutor/hxcpp
that referenced
this pull request
Mar 7, 2024
Haxe documentation specifies that an exception should be thrown if the path is not a valid directory. This was already the case on all platforms except Windows, where `null` was returned. Now the behavior is consistent. See: HaxeFoundation#1095
tobil4sk
added a commit
to tobil4sk/hxcpp
that referenced
this pull request
May 10, 2024
Haxe documentation specifies that an exception should be thrown if the path is not a valid directory. This was already the case on all platforms except Windows, where `null` was returned. Now the behavior is consistent. See: HaxeFoundation#1095
tobil4sk
force-pushed
the
fix/sys_read_dir_error
branch
from
cd31fff
to
cc67890
Compare
Haxe documentation specifies that an exception should be thrown if the path is not a valid directory. This was already the case on all platforms except Windows, where `null` was returned. Now the behavior is consistent.
tobil4sk
force-pushed
the
fix/sys_read_dir_error
branch
from
cc67890
to
e8d12a8
Compare
|
@Simn This one also seems to be affected by the flaky test. |
|
Looks green now! |
tobil4sk
added a commit
to soccertutor/hxcpp
that referenced
this pull request
Aug 28, 2024
Haxe documentation specifies that an exception should be thrown if the path is not a valid directory. This was already the case on all platforms except Windows, where `null` was returned. Now the behavior is consistent. See: HaxeFoundation#1095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haxe documentation specifies that an exception should be thrown if the path is not a valid directory:
This was already the case on all platforms except Windows, where
nullwas returned. Now the behavior is consistent.