Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling issues #986

Closed
CrazyFlasher opened this issue Jul 9, 2021 · 5 comments
Closed

Scaling issues #986

CrazyFlasher opened this issue Jul 9, 2021 · 5 comments

Comments

@CrazyFlasher
Copy link
Contributor

Sample on the site resizes fine:
https://heaps.io/samples/base2D/

However if I build from source, I get weird results:
image
@CrazyFlasher
Copy link
Contributor Author

image
for some reason, onResize is not called.
I've debugged sample here https://heaps.io/samples/base2D/ and onResize executes during stage resize

@CrazyFlasher
Copy link
Contributor Author

I guess I found a commit "Remove useless listener and timer" db3ddc3 :)
image
Looks like timer did the trick

@CrazyFlasher CrazyFlasher mentioned this issue Jul 9, 2021
Open
@CrazyFlasher
Copy link
Contributor Author

#987

@ncannasse
Copy link
Member

ping @trethaller

@trethaller
Copy link
Member

IIRC we mostly had issues with the Timer, not so much the resize callback, so I've merged you PR and will see if anything breaks on our end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ncannasse @trethaller @CrazyFlasher