-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Quest: mtb:scale #559
base: modified
Are you sure you want to change the base?
New Quest: mtb:scale #559
Conversation
Translations will be available in Weblate as soon as the PR is merged. (https://translate.codeberg.org/projects/scee/) |
Do I only need to supply the default or can I also put my language in? |
|
Default is english, your language will be overwritten from Weblate as far as I know. |
1 - Great |
I'm not very familiar with |
It helps, but to my knowledge it's less used than the scale, which is for descending. |
Similar to |
I think I've misunderstood the overlay, for me it's just an overlay, it doesn't let me know if any tags are missing. |
This morning I played with the overlays and I know why I don't use them. My use case: trail_visibility And then the width and incline as a bonus Unless I'm mistaken, if it's not quests I have to change overlay all the time? |
That is correct. Overlays were developed to provide a very specific type of information in a standardized and concentrated way. Personally, I also prefer to use quests instead of overlays, as I can add more diverse information this way. But in this case of the What is possible, however, is to combine several quests with one overlay. At least trail_visibility, smoothness, surface and tracktype are available as quests, then you could use the overlay for mtb:scale / sac_scale. Not ideal, but perhaps a compromise. |
@ravenfeld I think it's not only worth considering what you want to fill in, but what others might do. If you only care about your region and what you personally want to add when hiking, then of course there is little incentive for adding an SC overlay and a quest might be better for your use case. |
I'm looking into it, but it's a bit more complicated, especially the form. I'm going to propose an overlay for the |
Can't you just take the basic form e.g. from surface overlay?
You can also propose an overlay for |
Yes, I understand, but then I can cancel the PR for the sac_scale and keep the quest for myself. In my opinion, you have to try to be consistent. But I'll check with SC as the overlay is expected for mtb:scale. Then I'll propose what I'm doing on my fork, after that if it suits you no problem to close. |
I agree, as both tags are similar.
I would say From another point of view, one could also argue for the two quests in favor that both are always deactivated for all SCEE users in the beginning and must be actively activated, including a corresponding warning message when activating them. Anyone who is traveling in the middle of a big city and has the quest active and answers where it should not be should not call themselves an "expert". As the app says when you install it: with great functionality comes great responsibility. |
After setting up the relation=hiking for the sac_scale, I propose to do the same for the mtb:scale so that it corresponds to my use but also so as not to pollute people who don't want to indicate it everywhere. |
Every now and then I check notes created with SCEE, and in my opinion there are too many people who seem to have too little OSM knowledge. For this reason I want quests to have no spam-danger by default.
If for some reason you demand that it must be the same way of implementation, i.e. that I must accept the |
I'm not forcing anything, sorry if I worded that wrong. I'm bad at English and often use a translator to help me. I'm just trying to be consistent. It doesn't change the fact that I'm trying to get an Overlay to work right now so that I can offer it on SC, it's more the form that's still holding me back. |
Oh, sorry for misinterpreting yout post.
Yes, this would be fine (in case the overlay is not happening).
Is there anything specific you need help with? |
For the moment it's fine, the problem is that the images aren't of good quality, so I might open the PR and ask for help. I'm doing some tests today and it's possible that I'll suggest it to them later today. |
@ravenfeld Where did you get the new images? I can help you with make them smaller with better quality if you guide me to the original versions :) |
It's the one on the osm wiki and for mtb_scale 6 on the via ferrata. |
They are straight from the wiki page. @ravenfeld maybe we can just go forward and make a PR here for the overlay. I don't see the SC folks accepting this. The conversation is just running circles there. I'm also not sure the changes requested to the text were actually good. I feel like we should better stick to a longer text, explaining it like exactly like the original authors of the scale intended. As objectively there's no reason to not mention skill for example, or grade with percentage. Meaning those texts should be used:
|
@RubenKelevra I agree with you that it's all going round in circles. I suggested the code and now it's the descriptions and photos that are the problem. |
Why not? Just close the PR at SC, as it obviously not going forward there and we work here on the images and the text to fit the application. The original text is available in German, Englisch and Italian. The rest would need to be translated. And due to the text size it may make sense to have just the Scale 1-6 written next to the text and expand the text if the user clicks on it - if that's possible? |
Same principle as sac_scale but to indicate the mtb:scale.
I'd use the same filter and validate it as for sac_scale.
I still don't know how the PR works for translations, so I've only used the default.
I'm wondering about the relevance of the photos, in the group I'm in we're not fans of these photos and it's more by habit and practice that we know what value to put.
I did a quick icon but no problem for you to push another.