Skip to content

Install button shouldn't work if install path is empty #1234

Closed

Description

@arielj

Describe the bug

When trying to install a game, if the install path is empty, clicking the Install button closes the dialog with no information and nothing happens, and there's no indication of an error anywhere.

Add logs

not relevant

Steps to reproduce

  1. Open the install dialog for a game
  2. Make sure the Select Install Path field is empty
  3. Click the Install button
  4. Dialog closes, installation never starts, no errors are displayed anywhere (the code simply returns)

Expected behavior

Clicking the Install button shouldn't close the dialog and it should be clear what's the reason it's not installing.

I can imagine 2 options:

  • disable the Install button if the input is empty (though we still need to show some indication that it can't be empty)
  • leave the button enabled but show a message to the user if the input is empty

Screenshots

No response

System Information

  • OS [e. g. "Ubuntu"]: Linux Mint
  • Heroic Version [e. g. 2.1.1]: 2.3.0-beta.1

Additional information

No response

Activity

  1. added
    bug:unconfirmedSomeone works on identifying the issue
    issue:investigatingThis issue is being actively investigated.
    and removed
    bug:unconfirmedSomeone works on identifying the issue
    on Apr 24, 2022
  2. jadewilk commented on Apr 25, 2022

    @jadewilk
    Collaborator

    I see what you mean, I'm taking a look.

  3. self-assigned this
    on Apr 25, 2022
  4. jadewilk commented on Apr 25, 2022

    @jadewilk
    Collaborator

    Made a patch on #1239

  5. flavioislima commented on May 20, 2022

    @flavioislima
    Member

    fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions