Skip to content

Cancelling GOG games installation show game as installed #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arielj opened this issue Apr 28, 2022 · 0 comments · Fixed by #1254
Closed

Cancelling GOG games installation show game as installed #1251

arielj opened this issue Apr 28, 2022 · 0 comments · Fixed by #1254

Comments

@arielj
Copy link
Collaborator

arielj commented Apr 28, 2022

Describe the bug

When cancelling the installation of a GOG game, the installation is canceled, but the game status is updated as installed. It can be "uninstalled" sometimes but sometimes uninstalling the game fails because it can't find files to uninstall.

Add logs

Not relevant, the log shows that the installation process got killed as expected.

Steps to reproduce

  1. Open the GOG library
  2. Start installing a game
  3. After a moment, cancel the installation
  4. Game shows as installed
  5. Try to uninstall it, sometimes it will work and the game status changes to not installed, but sometimes it fails to uninstall

Expected behavior

Cancelling the installation should work like the epic library, it should NOT add the game in the installed games store.

Screenshots

No response

System Information

  • OS [e. g. "Ubuntu"]: Not relevant
  • Heroic Version [e. g. 2.1.1]: Main branch

Additional information

No response
@arielj arielj mentioned this issue Apr 28, 2022
Merged
4 tasks
flavioislima added a commit that referenced this issue Apr 29, 2022
@flavioislima
fix #1251
10b27f3
@flavioislima flavioislima linked a pull request Apr 29, 2022 that will close this issue
[Tech] Eslint Updates + Fix GOG Installing #1254
Merged
4 tasks
@flavioislima flavioislima mentioned this issue Apr 29, 2022
Merged
4 tasks
flavioislima added a commit that referenced this issue May 2, 2022
@flavioislima
[Tech] Eslint Updates + Fix GOG cancelling Install (#1254)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a1772a5 
* test

* fix #1251

* chore: update eslint rules + fix files

* chore: other lint fixes

* fix: any types

* chore: lint

* fix: use signal to check if install was canceled

* chore: lint

* fix: duplicate item when instaling

* chore: updated error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tech] Eslint Updates + Fix GOG Installing Heroic-Games-Launcher/HeroicGamesLauncher
1 participant
@arielj