Skip to content

Conversation

Vivalldi
Copy link
Contributor

Hey @HiDeoo!
Hope all is going well. Just added this new feature. Would love to see this added

Cheers,
Vivalldi

Added functionality for the `onBeforeExit` function. Would love to see this released.
Corrected logic - was always returning null
@HiDeoo
Copy link
Owner

HiDeoo commented Jan 11, 2018

Hi, thanks for your PR :)

Indeed, that seems like a pretty nice addition. I haven't look at the code / tests yet but if you manage to fix them I'll review everything at once and merge the PR.

If you need help regarding the tests, let me know and I'll take a look tomorrow.

PS: The new callback would also need to be documented in the README like the other ones.

@Vivalldi
Copy link
Contributor Author

Vivalldi commented Jan 12, 2018

Yeah I had realized that there we're checks after opening the pull. I'll be running through those shortly. Do you have a config file for prettier?

@HiDeoo
Copy link
Owner

HiDeoo commented Jan 12, 2018

No problem, and yes, the project was created a little bit before Prettier added support for .prettierrc and others config files and I never updated it with a proper config.

I'll make sure to add one before the next release, good call. In the meantime, you can find the options I used in the lint-staged configuration:

prettier --single-quote --trailing-comma es5 --print-width 120 --write

Or in the .eslintrc:

"prettier/prettier": [2, { printWidth: 120, singleQuote: true, trailingComma: "es5" }],

@Vivalldi
Copy link
Contributor Author

Having some issues mocking the onBeforeExit function...

@Vivalldi Vivalldi closed this Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants