Make brew typecheck --update --suggest-typed bump strictness further

[issyl0]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

• Not only false to true but true to strict.
• Only humans every run this, but our goal is to increase the typechecking in our files to get to strict everywhere so let's make that easy to remember to do.
• Inspired by Make more files Sorbet typed: strict #17410 (comment).

[apainintheneck]

The change looks good and works for me locally.

My only nit is that the brew type check --update --suggest-typed exits with a non-zero exit code when there are files that can be bumped up a strictness level. It seems like it should still exit successfully since this is only a suggestion.

Error: Failure while executing; `bundle exec spoom srb bump --dry --from true --to strict --sorbet /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-0.5.11406/bin/srb\ tc` exited with 1.

[MikeMcQuaid]

Thanks @issyl0!

My only nit is that the brew type check --update --suggest-typed exits with a non-zero exit code when there are files that can be bumped up a strictness level. It seems like it should still exit successfully since this is only a suggestion.

I think with --update supplied it should do the bumping for us automatically.

[apainintheneck]

Yeah, if that's possible, that would be great.

[issyl0]

Yeah, removing --dry should do it.

[MikeMcQuaid]

Ok, think this is working as expected then, thanks @issyl0!