Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make brew typecheck --update --suggest-typed bump strictness further #17411

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Make brew typecheck --update --suggest-typed bump strictness further #17411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Library/Homebrew/dev-cmd/typecheck.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,12 @@
safe_system "bundle", "exec", "parlour"

if args.suggest_typed?
ohai "Bumping Sorbet `typed` sigils..."
ohai "Checking if we can bump Sorbet `typed` sigils..."
# --sorbet needed because of https://github.com/Shopify/spoom/issues/488
safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--sorbet",
"#{Gem.bin_path("sorbet", "srb")} tc"
safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--from", "false", "--to", "true",

Check warning on line 63 in Library/Homebrew/dev-cmd/typecheck.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/dev-cmd/typecheck.rb#L63 

Added line #L63 was not covered by tests
"--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--from", "true", "--to", "strict",

Check warning on line 65 in Library/Homebrew/dev-cmd/typecheck.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/dev-cmd/typecheck.rb#L65 

Added line #L65 was not covered by tests
"--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
end

return
Expand Down