Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info: Fix style: Use a guard clause #5482

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Jan 4, 2019

Fix the style error:

Library/Homebrew/cmd/info.rb:88:7: C:
Use a guard clause instead of wrapping the code inside a conditional expression.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

See the Docker Hub build failure at https://cloud.docker.com/u/linuxbrew/repository/registry-1.docker.io/linuxbrew/brew/hub-builddetail/b65dbhtpfk5ywqqvfz5aeqh

Fix the style error:
Library/Homebrew/cmd/info.rb:88:7: C:
Use a guard clause instead of wrapping the code inside a conditional expression.
@sjackman sjackman self-assigned this Jan 4, 2019
@MikeMcQuaid MikeMcQuaid merged commit 66894b6 into Homebrew:master Jan 4, 2019
@MikeMcQuaid
Copy link
Member

Makes sense. Weird that this didn't fail our CI. Any ideas why @sjackman; what's different on Docker Hub? I'd also argue if our CI is green then Docker Hub's should be too.

@sjackman sjackman deleted the info-json branch January 4, 2019 21:55
@sjackman
Copy link
Member Author

sjackman commented Jan 4, 2019

Any ideas why @sjackman; what's different on Docker Hub?

No idea, sorry. My best guess would be a different version of rubocop somehow?

I'd also argue if our CI is green then Docker Hub's should be too.

Yes, I agree. I just don't have the time right now to dig into it. Thanks for merging though.

@lock lock bot added the outdated PR was locked due to age label Feb 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants