Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.test.yml: Run brew test-bot as linuxbrew #5760

Merged
merged 1 commit into from
Feb 17, 2019

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Feb 17, 2019

Running brew test-bot as root fails.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

==> brew update-test --to-tag
==> FAILED
Start commit: 1facac803ee3e4bfe78adcbff5dcd476abc1f378
End commit: d27320087aa8f8a6653db93ff925e7b9c05bea8d
==> Setup test environment...
Cloning into '.'...
done.
Cloning into bare repository 'remote.git'...
done.
Reset branch 'master'
Your branch is up to date with 'origin/master'.
Everything up-to-date
HEAD is now at 1920eecb7 Merge pull request #5651 from retokromer/patch-1
==> Running brew update...
Error: Running Homebrew as root is extremely dangerous and no longer supported.
As Homebrew does not drop privileges on installation you would be giving all
build scripts full access to your system.
Error: Failure while executing; `brew update --verbose` exited with 1.

My best guess is that

  • brew update-test --to-tag switches to the most stable release of Homebrew
  • the most recent stable release of Homebrew does not permit being run as root
  • brew udpate fails

The change to Dockerfile.test.yml could likely be reverted after the next stable release of Homebrew (2.0.2).

@sjackman sjackman self-assigned this Feb 17, 2019
@sjackman sjackman added the bug Reproducible Homebrew/brew bug label Feb 17, 2019
Running brew test-bot as root fails.

==> Running brew update...
Error: Running Homebrew as root is extremely dangerous and no longer supported.
@sjackman sjackman merged commit 2864ed9 into Homebrew:master Feb 17, 2019
@sjackman sjackman deleted the dockerfile-test branch February 17, 2019 05:06
@lock lock bot added the outdated PR was locked due to age label Mar 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant