Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixtures: add test.dmg #9499

Merged
merged 1 commit into from
Dec 10, 2020
Merged

fixtures: add test.dmg #9499

merged 1 commit into from
Dec 10, 2020

Conversation

fxcoudert
Copy link
Member

Tests that were previously calling hdiutil create are now failing with sandbox restrictions. Let's add DMG images (as small as possible, 400 kB) to the test fixtures.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-11 at 11:08:09 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 10, 2020
@fxcoudert fxcoudert mentioned this pull request Dec 10, 2020
Closed
MikeMcQuaid
MikeMcQuaid approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to make this smaller if possible (perhaps gzipping it?) but otherwise: 👍🏻

@fxcoudert
Copy link
Member Author

I thought dmg's were already zipped, but they're not… great idea!

@fxcoudert fxcoudert added the critical Critical change which should be shipped as soon as possible. label Dec 10, 2020
@fxcoudert
Copy link
Member Author

(It's not critical but given the scope I don't think the one-day review period should apply)

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 10, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 10, 2020 •
edited
Loading

Review period ended.

MikeMcQuaid
MikeMcQuaid approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

400KB -> 3.66KB: 🎉

@reitermarkus
Copy link
Member

Does this contain any files?

@reitermarkus
Copy link
Member

There is already a DMG in Library/Homebrew/test/support/fixtures/cask/transmission-2.61.dmg.

@reitermarkus
Copy link
Member

Nevermind, I realize now that this it supposed to be a replacement for hdiutil create.

@fxcoudert fxcoudert merged commit c7ef48a into Homebrew:master Dec 10, 2020
@fxcoudert fxcoudert deleted the dmg branch December 10, 2020 13:57
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 10, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fxcoudert @BrewTestBot @reitermarkus @MikeMcQuaid