Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run sorbet workflow on Big Sur. #9508

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Run sorbet workflow on Big Sur. #9508

merged 1 commit into from
Dec 11, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Dec 11, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Avoid diff changing back and forth between Catalina and Big Sur.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-14 at 02:50:43 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 11, 2020
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 11, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 11, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 11, 2020 •
edited
Loading

Review period ended.

@reitermarkus reitermarkus merged commit 5ad24ec into master Dec 11, 2020
@reitermarkus reitermarkus deleted the sorbet branch December 11, 2020 13:51
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 11, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reitermarkus @BrewTestBot @MikeMcQuaid