Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-upload: tighten json_files glob #9530

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

dawidd6
Copy link
Contributor

@dawidd6 dawidd6 commented Dec 12, 2020

Tighten the glob, so we won't accidentaly parse arbitrary JSON files and only valid bottle ones.

I bumped into an issue in my tap today where tap_migrations.json was read first.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-15 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 12, 2020
@dawidd6 dawidd6 added critical Critical change which should be shipped as soon as possible. and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Dec 12, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 12, 2020

Review period ended.

@dawidd6 dawidd6 force-pushed the tighten-bottle-json branch from bbb4b1e to d91e535 Compare December 12, 2020 21:59
@dawidd6 dawidd6 merged commit 12d8d6d into Homebrew:master Dec 12, 2020
@dawidd6 dawidd6 deleted the tighten-bottle-json branch December 12, 2020 22:21
@MikeMcQuaid
Copy link
Member

Good catch!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 14, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants