Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Over zealous cask name matching? #998

Closed
oldskool73 opened this issue Sep 9, 2013 · 5 comments
Closed

Over zealous cask name matching? #998

oldskool73 opened this issue Sep 9, 2013 · 5 comments

Comments

@oldskool73
Copy link
Contributor

There's not a cask for Unity (the 3d app), so I tried to create one...

➜  phinze-cask git:(master) brew cask create unity
Error: Cask for unity already exists. Use `brew cask edit unity` to see it.
➜  phinze-cask git:(master) brew cask search unity
intellij-community
➜  phinze-cask git:(master) brew cask edit unity

...opens the intellij-community cask for editing. The name matching seems to be a little over zealous, creating a false match?
@phinze
Copy link
Contributor

phinze commented Sep 9, 2013

Ha! That's exactly what's happening. How weird. Should be a quick fix; stay tuned...

@oldskool73
Copy link
Contributor Author

So for my requirements I just cheated and called the new cask Unity3d (#1000), but this is still a valid bug I guess.

@phinze phinze mentioned this issue Sep 9, 2013
Merged
phinze added a commit that referenced this issue Sep 9, 2013
@phinze
fix overzealous cask already created error
fbc246f 
this prevented any cask being created via `brew cask create` that was a
suffix substring of an existing cask.

refs #998
@nanoxd
Copy link
Contributor

nanoxd commented Sep 12, 2013

@phinze Do we still need this open?

@phinze
Copy link
Contributor

phinze commented Sep 12, 2013

Guess so - I was waiting for somebody to confirm but I think we're good. 🍭

@phinze phinze closed this as completed Sep 12, 2013
@nanoxd
Copy link
Contributor

nanoxd commented Sep 12, 2013

I just tested it and it works 😄 I created a cask named bunity (points for originality) and it did not complain

@vitorgalvao vitorgalvao mentioned this issue Sep 17, 2013
Closed
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phinze @oldskool73 @nanoxd