Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fl-studio 24.2.0.4161 #193773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fl-studio 24.2.0.4161 #193773

wants to merge 1 commit into from

Conversation

khipp
Copy link
Member

@khipp khipp commented Nov 30, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@khipp khipp mentioned this pull request Nov 30, 2024
@khipp khipp force-pushed the update-fl-studio branch 3 times, most recently from 335a51f to c939a8c Compare December 2, 2024 08:41

url "https://demodownload.image-line.com/flstudio/flstudio_mac_#{version}.dmg",
url "https://install.image-line.com/flstudio/flstudio_mac_#{version}.dmg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url "https://install.image-line.com/flstudio/flstudio_mac_#{version}.dmg",
url "https://support.image-line.com/redirect/flstudio_mac_installer",

If we unversion the download it seems to negotiate what it needs to pull from the right url after the redirect, but doesn't seem to work on the direct link.

Copy link
Member Author

@khipp khipp Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll give it a try.

I handled the last few bumps, and it would always work fine eventually after a few days. I'm not sure what the exact issue is, but they are using Cloudflare, which might be blocking requests too quickly after new releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp didn't work anyway 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bevanjkay It seems that upstream uses the _cfuvid and cf_clearance Cloudflare cookies to filter requests. Fetching the previous version 24.1.2.4074 no longer works on my end either. Could you confirm this by running brew fetch?

Unless we can find a workaround to provide a stable download, it might be better to disable the cask.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent results for me.

One system I can brew fetch, one I cannot, for version 24.1.2.4074

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can brew fetch.

@khipp khipp force-pushed the update-fl-studio branch 4 times, most recently from c80a75e to bf20ef4 Compare December 9, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants