Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audit for versioned casks with no checksum #4743

Merged
merged 2 commits into from
Jun 7, 2014
Merged

Add audit for versioned casks with no checksum #4743

merged 2 commits into from
Jun 7, 2014

Conversation

nanoxd
Copy link
Contributor

@nanoxd nanoxd commented Jun 7, 2014

  • Check if version is not latest and has a sha256 :no_check for checksum

@nanoxd
Add audit for versioned casks with no checksum
a4d479c 
* Check if version is not latest and has a sha256 :no_check for checksum
@nanoxd
Fix SwitchResX with a version and sha256 to pass test
548fb01
@nanoxd
Copy link
Contributor Author

nanoxd commented Jun 7, 2014

Tests failed due to SwitchResX not having a checksum but being versioned.

@rolandwalker
Copy link
Contributor

Duplicates #3556 ?

@rolandwalker
Copy link
Contributor

In any case #3556 uses the old form no_checksum and will no longer work. (It fell through the cracks because for most of its life it has been in a state of merge conflict.)

rolandwalker added a commit that referenced this pull request Jun 7, 2014
@rolandwalker
Merge pull request #4743 from NanoXD/add_versioned_cask_with_no_check…
f0ea053 
…sum_test

Add audit for versioned casks with no checksum
@rolandwalker rolandwalker merged commit f0ea053 into Homebrew:master Jun 7, 2014
@nanoxd nanoxd deleted the add_versioned_cask_with_no_checksum_test branch June 7, 2014 18:04
@rolandwalker rolandwalker mentioned this pull request Jun 7, 2014
Closed
@rolandwalker rolandwalker mentioned this pull request Dec 17, 2014
Merged
rolandwalker added a commit to rolandwalker/homebrew-cask that referenced this pull request Dec 17, 2014
@rolandwalker
sha256 :no_check overrides version <string>
1413bea 
This behavior was traditionally present, and is now recovered
by removing the audit test added in Homebrew#4743.  The doc is clarified
but did not require major change.

closes: Homebrew#6356
refs: Homebrew#8179
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanoxd @rolandwalker