-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python@2: delete #49796
python@2: delete #49796
Conversation
As decided during FOSDEM with the other maintainers, and announced here: We will remove python@2 on Monday February 10. |
Needs the alias removed too |
EOL 1 January 2020. We gave it 1 month more to live so that people had time to migrate. All in all, developers had 11 years to do their migration. You can use the `brew extract` command and maintain python@2 in your own tap if necessary: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap
c54d0fd
to
22eb595
Compare
Homebrew is removing python@2 on February 10, 2020 (Homebrew/homebrew-core#49796) and they have been gradually working on getting rid of the related code from the formulas. One of our dependencies, numpy has already dropped support. We can no longer support python@2.
Are the bottles also removed? I guess what I'm asking is, would it make sense to keep this in a tap? bottle do
sha256 "accfaa922708f00afb69ab230199f96e6ecdddd248a1eca586ce1e5e5cfd732b" => :catalina
sha256 "54d3351d6be8268b2f5017894dcc8e083811dfa3812bdb9f79f989873b9a4542" => :mojave
sha256 "cfd5c6eeac37065d19f527bb0798a9caf1928bab3340cd545224861a3c82f219" => :high_sierra
end |
They might be removed, they might be removed in the future. Bottles are only supposed to work for the current formula. |
The problem is, I have some a brew formula that depends on python@2. So is there another way to put it in a tap? |
If it's for macOS, the OS also ships with a python 2 version. |
Just FYI, https://docs.brew.sh/Homebrew-and-Python still says Homebrew provides |
@iMichka got time to fix that? |
I'm working on a PR for brew. |
I can’t reproduce this. Can you give an example? |
See Homebrew/brew#7019 for the documentation and code update in brew. |
Sure:
Modify the test section to read
Then
|
This formula was deleted. Homebrew/homebrew-core#49796
This formula was deleted. Homebrew/homebrew-core#49796
This formula was deleted. Homebrew/homebrew-core#49796
`brew install python@2` now fails for me locally due to Homebrew/homebrew-core#49796, not sure how it still runs fine on CI, probably due to caches not being cleaned up as frequently. I hope relying on system-installed Python should work fine.
Summary: The function attributes named func_X have been renamed to use the __X__ form in Python3, https://docs.python.org/3/whatsnew/3.0.html#operators-and-special-methods and also built-in changes https://wiki.python.org/moin/Python3.0#Built-In_Changes. The old names can't be used in Python3. This PR changes the old names to new names to make buck Python3 compatible. Python2 was EOL on 1/1/2020, Homebrew/homebrew-core#49796. Pull Request resolved: #2391 Reviewed By: philipjameson, v-jizhang Pulled By: v-jizhang shipit-source-id: c00dae81ea0e0356ebacb2429ddee26bb8fe9362
EOL 1 January 2020.
We gave it 1 month more to live so that people had time to migrate.
All in all, developers had 11 years to do their migration.
You can use the
brew extract
command and maintain python@2 in your owntap if necessary:
https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?