Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashicorp: deprecate and add caveat #139538

Merged
merged 1 commit into from Apr 5, 2024
Merged

hashicorp: deprecate and add caveat #139538

merged 1 commit into from Apr 5, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 14, 2023 •
edited by chenrui333

Inform users that we might disable this forumula one day given there will be no more version updates in homebrew-core due to the license change

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

closes #168090

@iMichka iMichka added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 14, 2023
@iMichka iMichka requested a review from a team August 14, 2023 21:11
@github-actions github-actions bot added go Go use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Aug 14, 2023
@chenrui333 chenrui333 added the maintainer feedback Additional maintainers' opinions may be needed label Aug 14, 2023
p-linnane
p-linnane reviewed Aug 14, 2023
View reviewed changes
Formula/terraform.rb Outdated Show resolved Hide resolved
Formula/terraform.rb Outdated Show resolved Hide resolved
Formula/terraform.rb Outdated Show resolved Hide resolved
ZhongRuoyu
ZhongRuoyu reviewed Aug 14, 2023
View reviewed changes
Formula/terraform.rb Outdated Show resolved Hide resolved
@Bo98
Copy link
Member

Bo98 commented Aug 15, 2023 •
edited

Not sure if it's necessarily worth elaborating on: but as it stands future releases prior to 1.6.0 will be acceptable, though it's possible there won't be any such release.

carlocab
carlocab reviewed Aug 15, 2023
View reviewed changes
Formula/terraform.rb Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @iMichka! Looks great so far. A few thoughts.

Formula/terraform.rb Outdated Show resolved Hide resolved
Formula/terraform.rb Outdated Show resolved Hide resolved
Formula/terraform.rb Outdated Show resolved Hide resolved
Formula/terraform.rb Outdated Show resolved Hide resolved
@iMichka iMichka mentioned this pull request Aug 22, 2023
Merged
6 tasks
@chenrui333 chenrui333 mentioned this pull request Aug 23, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Sep 6, 2023
@fxcoudert
Copy link
Member

@iMichka gentle ping on that review feedback

@fxcoudert fxcoudert removed the stale No recent activity label Sep 6, 2023
iMichka added a commit to iMichka/brew that referenced this pull request Sep 6, 2023
@iMichka
terraform: add audit for relicensing
a24d15d 
See also
Homebrew/homebrew-core#139538
@iMichka iMichka mentioned this pull request Sep 6, 2023
Merged
7 tasks
@iMichka
Copy link
Member Author

iMichka commented Sep 6, 2023

Done. Sorry for the delay

MikeMcQuaid
MikeMcQuaid approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iMichka!

@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 7, 2023
chenrui333
chenrui333 reviewed Sep 12, 2023
View reviewed changes
Formula/t/terraform.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Sep 12, 2023
View reviewed changes
Formula/t/terraform.rb Outdated Show resolved Hide resolved
iMichka added a commit to iMichka/homebrew-core that referenced this pull request Mar 13, 2024
@iMichka
cdktf: deprecate
046de0d 
This uses soon-to-be deprecated terraform: Homebrew#139538
This is one of the last formulae that blocks the terraform deprecation

The formula has more tha 700 downloads / months, and is not impacted by the BUSL license change (even while being hosted in the hashicorp GitHub org).
There seem also not to be any hint of the an equivalent formula in upstream's tap, but it's probably pretty easy for them to add it
@iMichka iMichka mentioned this pull request Mar 13, 2024
Merged
6 tasks
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 15, 2024
@cho-m cho-m added CI-no-bottles Merge without publishing bottles and removed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Mar 15, 2024
@cho-m cho-m removed the request for review from carlocab March 15, 2024 13:49
@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Mar 15, 2024
@iMichka iMichka mentioned this pull request Apr 3, 2024
Merged
6 tasks
@iMichka iMichka marked this pull request as ready for review April 4, 2024 21:20
@iMichka
Copy link
Member Author

iMichka commented Apr 4, 2024

This should be good now, I took care of all the dependencies.

@p-linnane
Copy link
Member

Just a nit, but since this has already happened we can probably remove all the future tense language.

@iMichka
terraform: deprecate and add caveat
1c7b99b 
Inform users that we will disable this forumula one day given there will
be no more version updates in homebrew-core due to the license change
@iMichka
Copy link
Member Author

iMichka commented Apr 4, 2024

Just a nit, but since this has already happened we can probably remove all the future tense language.

Done; this pull request feels so old now :)

p-linnane
p-linnane approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your hard work here!

@p-linnane p-linnane enabled auto-merge April 4, 2024 21:39
@p-linnane
Copy link
Member

Might need to open a new PR. The approval isn't registering.

@ZhongRuoyu ZhongRuoyu mentioned this pull request Apr 5, 2024
Merged
@p-linnane p-linnane added this pull request to the merge queue Apr 5, 2024
Merged via the queue into Homebrew:master with commit 4782218 Apr 5, 2024
32 checks passed
@iMichka iMichka deleted the terraform branch April 6, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikaro nikaro nikaro left review comments

@ZhongRuoyu ZhongRuoyu ZhongRuoyu left review comments

@carlocab carlocab carlocab left review comments

@bschaatsbergen bschaatsbergen bschaatsbergen left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
busl-license CI-no-bottles Merge without publishing bottles CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue maintainer feedback Additional maintainers' opinions may be needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet