Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradio 7.1 (new formula) #30602

Closed
wants to merge 4 commits into from
Closed

gradio 7.1 (new formula) #30602

wants to merge 4 commits into from

Conversation

krrk
Copy link
Contributor

@krrk krrk commented Jul 30, 2018

to internet radio stations

It appears as though most of the app is working except for some of the
GTK3 menu icons and I'm not sure if that is an upstream bug or a problem
with the build.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

to internet radio stations

It appears as though most of the app is working except for some of the
GTK3 menu icons and I'm not sure if that is an upstream bug or a problem
with the build.
@BrewTestBot
Copy link
Member

  • C: 10: col 3: dependency "gettext" (line 10) should be put before dependency "ninja" (line 9)
  • C: 12: col 3: dependency "gtk+3" (line 12) should be put before dependency "python" (line 11)
  • C: 13: col 3: dependency "glib" (line 13) should be put before dependency "python" (line 11)
  • C: 14: col 3: dependency "libsoup" (line 14) should be put before dependency "python" (line 11)
  • C: 15: col 3: dependency "json-glib" (line 15) should be put before dependency "python" (line 11)
  • C: 16: col 3: dependency "gstreamer" (line 16) should be put before dependency "python" (line 11)
  • C: 17: col 3: dependency "gst-plugins-base" (line 17) should be put before dependency "python" (line 11)
  • C: 19: col 3: dependency "sqlite" (line 19) should be put before dependency "gst-libav" (line 18)
  • C: 20: col 3: dependency "cairo" (line 20) should be put before dependency "gst-libav" (line 18)
  • Formulae should not have optional or recommended dependencies
  • Dependency 'sqlite' may be unnecessary as it is provided by macOS; try to build this formula without it.
  • Formulae should not have optional or recommended dependencies
  • Dependency 'sqlite' may be unnecessary as it is provided by macOS; try to build this formula without it.
  • Formulae should not have a HEAD or devel spec

@BrewTestBot
Copy link
Member

  • C: 9: col 3: dependency "gettext" (line 9) should be put before dependency "cairo" (line 8)
  • C: 12: col 3: dependency "gst-libav" (line 12) should be put before dependency "gstreamer" (line 11)
  • C: 13: col 3: dependency "gst-plugins-base" (line 13) should be put before dependency "gstreamer" (line 11)
  • C: 16: col 3: dependency "json-glib" (line 16) should be put before dependency "libsoup" (line 15)
  • C: 17: col 3: dependency "meson" (line 17) should be put before dependency "libsoup" (line 15)
  • C: 18: col 3: dependency "ninja" (line 18) should be put before dependency "libsoup" (line 15)
  • Formulae should not have a HEAD or devel spec

@commitay commitay changed the title gradio 7.1 (new formula): Gradio is a GTK3 app for finding and listening gradio 7.1 (new formula) Jul 30, 2018
@commitay commitay added the new formula PR adds a new formula to Homebrew/homebrew-core label Jul 30, 2018
I reordered the dependencies according to BrewTestBot, changed the
description according to `brew audit --strict`, and added a new
dependency which fixes the missing icons in the main window.
@BrewTestBot
Copy link
Member

  • C: 15: col 3: dependency "adwaita-icon-theme" (line 15) should be put before dependency "gtk+3" (line 14)
  • C: 17: col 3: dependency "meson" (line 17) should be put before dependency "json-glib" (line 16)
  • C: 18: col 3: dependency "ninja" (line 18) should be put before dependency "json-glib" (line 16)
  • Formulae should not have a HEAD or devel spec

`brew audit --new-formula` no longer has any complaints and I changed
gettext to a runtime dependency as necessary
@ilovezfs
Copy link
Contributor

Thanks for the 🆕 formula @krrk! 📻

@ilovezfs ilovezfs closed this in 390a668 Jul 31, 2018
@lock lock bot added the outdated PR was locked due to age label Aug 30, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 30, 2018
@krrk krrk deleted the gradio branch November 13, 2018 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants