gnutls: build with unbound/dane support

[schanzen]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

I know that the changes are suboptimal, especially the manual changes of CFLAGS/LDFLAGS for unbound.
gnutls does not support supplying the unbound prefix so I am not sure how to solve it.
Also, it would probably be better to make this optional?
Pointers would be helpful.

[javian]

Are you sure these are needed ? pkg-config and homebrew ought to figure this out.

[schanzen]

Thanks for looking at it. Yes you are correct and I knew about this feature it just wasn't working.
Maybe I got it mixed up.
I added an update that removes the flags and makes the unbound dependency optional.

[schanzen]

EDIT: I see "optional" is frowned upon according to the cookbook. So what is preferred, making it recommended or just a regular depenency?

Now I get:
gnutls:

• Formulae should not have optional or recommended dependencies
  Error: 1 problem in 1 formula detected

when I check it with brew audit. Why?

[javian]

@schanzen options are no longer allowed so if you want it in it needs to be made the default.

[schanzen]

Removed the optional. Thanks for the guidance.

[javian]

@BrewTestBot test this please

[javian]

@BrewTestBot test this please

[javian]

Thanks @schanzen for putting this together and welcome to the Homebrew community! Without people like you it wouldn't flourish and continue to grow and live as it does.