-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm 3.9.0 #4579
llvm 3.9.0 #4579
Conversation
Will also need to bump the revisions on |
@DomT4 increased revision in all formulas which have Shall we do the same for formulas with |
5f3d264
to
4833cca
Compare
I feared as much, to be honest. LLVM updates are usually pretty hard to get through. Let's see what the response is from upstreams as to whether this is something we can get done quickly through patch backports or new releases, but otherwise we might have to consider adding the 3.9.0 release as a new formula & migrating things over as possible.
We don't bother; option usage is generally fairly low & forcing everyone to do a rebuild to cover the small minority that use those options isn't worthwhile. |
Strange, |
According to release notes |
Seems that |
Patch from |
😋 |
|
@Marqin thank you for notification. |
Looks like @BrewTestBot can't eat PRs containing merges from master with resolution of conflicts, so instead rebased this branch. |
😋 Thanks again for notification @Marqin 👍 |
btw. could it be possible to add this as standalone |
@Marqin I don't think the same question in multiple places gives any speedup. And as stated in https://github.com/Homebrew/homebrew-versions/blob/19e6a94df3130a8038789aa5c1dcd5eccffc5850/.github/ISSUE_TEMPLATE.md
So to really speedup the process - IMO either provide a PR yourself for the opened issue, either help finalize an existing PR 😉 |
3d2a7e0
to
bede48d
Compare
😋 |
@DomT4 maybe you have an advice? |
@Godin I updated castxml separately, because the old URL's were broken and there were no Sierra bottles. You can rebase your PR. Of course the patch for llvm 3.9 needs to stay the time being. P.S. thanks for pushing llvm 3.9 forward 👍 |
@JohanEngelen @John-Colvin thx for notification, rebased and |
@Godin looks like ponyc needs a little conflict resolution |
@Godin there's a crystal-lang PR adding 3.9 support now crystal-lang/crystal#3439 if you'd like to test it out! |
@ilovezfs yup, |
😋 However I did not checked whether it actually works or not. |
(Note that LDC has a chicken-egg problem with this: we use homebrew in our CI tests to install LLVM. Because LLVM3.9 is not available yet, we also can't test whether LDC works with LLVM3.9 on Mac...) |
I don't see any reason to wait on crystal-lang/crystal#3439. |
@Godin Thanks for your excellent work on this PR and your contribution to Homebrew! 🎆 |
@JohanEngelen chicken and egg problem solved :) |
@ilovezfs It would help me a lot if Edit: see https://travis-ci.org/ldc-developers/ldc/jobs/171078525 , line 101, for the failure with |
@JohanEngelen You can add a symlink in
|
The reason I want to type |
I'd recommend using your own tap in that case. |
@JohanEngelen @ilovezfs Hopefully someone will make an llvm39 formula https://github.com/Homebrew/homebrew-versions/blob/master/llvm38.rb |
llvm.rb in core is the llvm39 formula. |
I'd much appreciate the copy-paste from homebrew-core/llvm.rb to homebrew-versions/llvm39.rb ! |
@JohanEngelen You can do that in your own tap ... it's not difficult to set up: https://github.com/Homebrew/brew/blob/master/docs/How-to-Create-and-Maintain-a-Tap.md |
This is very frustrating. Installing an arbitrary version of llvm ( |
I'm not sure what reaction you expected with "I have no clue about homebrew contribution guidelines and do not wish to know."
Which is why we allow you to install older versions in homebrew/versions, any version pinned to a version from your own tap and are working on improving our versions support (Homebrew/brew#620).
The large numbers of people doing
I'm not sure what this is meant to communicate to us. You can make your TravisCI job install MacPorts, checkout a specific version of Homebrew and disable auto-update, install from your own tap, etc. If you'd behaved a little differently I'd be willing to help you do that but you didn't so I'm not, sorry. |
creduce
ponyc
castxml
ldc devel
ldc
crystal-lang