Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockutil 3.0.2 #97394

Closed
wants to merge 1 commit into from
Closed

dockutil 3.0.2 #97394

wants to merge 1 commit into from

Conversation

sashkab
Copy link
Contributor

@sashkab sashkab commented Mar 20, 2022 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added macos-only Formula depends on macOS swift Swift use is a significant feature of the PR or issue labels Mar 20, 2022
@sashkab sashkab changed the title dockutil: upgrade to 3.0.2 dockutil 3.0.2 Mar 20, 2022
SMillerDev
SMillerDev reviewed Mar 21, 2022
View reviewed changes
Formula/dockutil.rb Outdated Show resolved Hide resolved
Formula/dockutil.rb Outdated Show resolved Hide resolved
@SMillerDev SMillerDev added the needs response Needs a response from the issue/PR author label Mar 21, 2022
@sashkab sashkab force-pushed the docutil-3.0.2 branch 6 times, most recently from bf4acad to c15fa35 Compare March 22, 2022 19:07
@sashkab sashkab mentioned this pull request Mar 22, 2022
Closed
@sashkab
Copy link
Contributor Author

sashkab commented Mar 22, 2022

Reasoning for all the hell I'm currently going through:

I could have used xcodebuild, but I was running into sandboxing issue (see Homebrew/discussions#59 for details). So instead of trying to figure that out, I'm converting dockutil into a swift package and building it with swift build ...... Binary works, but I can't get dockutil --version not to crash, because I have no idea how to make swift package to read/update/use Info.plist, which is usually handled by the xcodebuild...

Only possible solution I see so far, patch source to hardcode the version...

Any help is appreciated!...

@sashkab sashkab force-pushed the docutil-3.0.2 branch 2 times, most recently from 7506c48 to c6008d8 Compare March 22, 2022 22:09
@sashkab
Copy link
Contributor Author

sashkab commented Mar 22, 2022

@SMillerDev this is now passing CI and ready for your review. Requiring Xcode 12.5 to avoid 10.15 build. seems swift build... on that OS does not support --disable-sandbox option, causing build issues.

SMillerDev
SMillerDev reviewed Mar 23, 2022
View reviewed changes
Formula/dockutil.rb
depends_on :macos

# Create Package.swift
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be submitted upstream

Copy link
Contributor Author

@sashkab sashkab Mar 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no problem building dockutil upstream. Problem, as I explained is within Homebrew. Therefore in order to workaround these problems, the patch was created. If you believe this is unacceptable, then I see only one way of handling this upgrade of dockutil:

  1. Remove formulae for dockutil from homebrew-core.
  2. Add formulae for dockutil into homebrew-cask.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or:

  1. Make a PR that allows people to use swift build to build the package from upstream
  2. ???
  3. profit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there hasn't been any upstream response and this is currently non-functional on 12.3 without a python, should we consider merging either this patch or the one from the pending PR kcrawford/dockutil#131?

@sashkab sashkab mentioned this pull request Mar 23, 2022
Closed
@shmileee shmileee mentioned this pull request Mar 29, 2022
Open
@tuxpeople tuxpeople mentioned this pull request Apr 1, 2022
Closed
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Apr 13, 2022
@sashkab
Copy link
Contributor Author

sashkab commented Apr 14, 2022

still waiting for upstream...

@github-actions github-actions bot removed the stale No recent activity label Apr 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label May 8, 2022
@sashkab
Copy link
Contributor Author

sashkab commented May 8, 2022

Still did not hear back from upstream.

0x2615 added a commit to 0x2615/workstation-setup that referenced this pull request May 24, 2022
@0x2615
Switch to using thirdparty cask for dockutil
0e811d8 
- This is intended as a temporary change
- Waiting on PR: Homebrew/homebrew-core#97394 to
  update dockutil to version 3.0.2

Authored-by: Sam Mirza <mirzasa@vmware.com>
@0x2615 0x2615 mentioned this pull request May 24, 2022
Merged
joemoore pushed a commit to pivotal/workstation-setup that referenced this pull request Jun 3, 2022
@0x2615 @joemoore
Switch to using thirdparty cask for dockutil
dec2fe3 
- This is intended as a temporary change
- Waiting on PR: Homebrew/homebrew-core#97394 to
  update dockutil to version 3.0.2

Authored-by: Sam Mirza <mirzasa@vmware.com>
wjam added a commit to wjam/dotfiles that referenced this pull request Jun 12, 2022
@wjam
Workaround dockutil issue
441a0fc 
dockutil 2.x is implemented in Python but the Homebrew formula for it
doesn't package Python with it, so is broken on the 12.3. 3.x is a
simple binary written in Swift, so doesn't have this issue, but it
currently isn't in Homebrew yet (see
Homebrew/homebrew-core#97394)
@bevanjkay bevanjkay mentioned this pull request Jun 18, 2022
Closed
9 tasks
@Mayurifag
Copy link

When this gonna be merged? dockutil version from brew is unusable due to python hell now

@einSelbst einSelbst mentioned this pull request Jun 19, 2022
Closed
@SMillerDev
Copy link
Member

When it's done and someone had time to review it. We're waiting for dockutil upstream now though.

@SMillerDev
Copy link
Member

If you want to complain in a pull request, complain here: kcrawford/dockutil#131 since that's what we're waiting for.

clhynfield added a commit to clhynfield/mac-dev-playbook that referenced this pull request Jul 22, 2022
@clhynfield
Use dockutil v3 [workaround cask][1]
9fe0931 
…at least until [dockutil updates to Swift package management][2] and
[Homebrew updates to dockutil v3][3].

[1]: kcrawford/dockutil#127 (comment)
[2]: kcrawford/dockutil#131
[3]: Homebrew/homebrew-core#97394
apoxa added a commit to apoxa/ansible-workstation that referenced this pull request Aug 10, 2022
@apoxa
Use dockutil v3 [workaround cask][1]
68bdded 
…at least until [dockutil updates to Swift package management][2] and
[Homebrew updates to dockutil v3][3].

[1]: kcrawford/dockutil#127 (comment)
[2]: kcrawford/dockutil#131
[3]: Homebrew/homebrew-core#97394
@cho-m cho-m added the upstream issue An upstream issue report is needed label Sep 16, 2022
@fxcoudert
Copy link
Member

At this point, I'd suggest closing the PR. It is an upstream issue, there is a patch, that they haven't reviewed in months. I'm sorry for users of this project, but we are not its maintainers.

@sashkab
Copy link
Contributor Author

sashkab commented Oct 4, 2022

I would wait a bit -- new version of macOS is expected soon, so, perhaps, they will resume some activity. If there will be no movements until November, I'll close MR. Hope this is ok?

@p-linnane p-linnane mentioned this pull request Nov 6, 2022
Closed
9 tasks
@SMillerDev SMillerDev removed the in progress Stale bot should stay away label Nov 6, 2022
@iMichka
Copy link
Member

iMichka commented Nov 28, 2022

We are now end of november and still no upstream activity. I'm going to close this.

Not that if the package does not build anymore or upstream has no activity, this will go through a deprecation phase and be removed from homebrew. We are not there yet, but might be in a few months.

@iMichka iMichka closed this Nov 28, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
@sroberts sroberts mentioned this pull request Jan 14, 2023
Merged
@phinze phinze mentioned this pull request Feb 13, 2023
Closed
@p-linnane p-linnane mentioned this pull request Aug 19, 2023
Open
9 tasks
@Homebrew Homebrew unlocked this conversation Oct 29, 2023
@chenrui333
Copy link
Member

FYI, upstream has just merged the swift package manager support PR, and the HEAD build works for me, so I am requesting a new release so that we can continue in a new release.

@sashkab
Copy link
Contributor Author

sashkab commented Oct 30, 2023

@chenrui333 as soon as they will cut new version, I can rebase and see if this can be resurrected.

@chenrui333
Copy link
Member

yeah, we can do that as well. (and also add a head build so that for future it can be built from head commit)

@sashkab
Copy link
Contributor Author

sashkab commented Oct 31, 2023

here is draft. Don't want to submit until 3.0.3 or 3.1 is tagged, but added HEAD https://github.com/Homebrew/homebrew-core/compare/master...sashkab:homebrew-core:dockutil-3.0.2b?expand=1

@chenrui333
Copy link
Member

While waiting for the new release, folks can install the HEAD commit after this PR. Thanks @danielbayley for taking on it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@branchvincent branchvincent branchvincent left review comments

@SMillerDev SMillerDev SMillerDev left review comments

Assignees
No one assigned
Labels
macos-only Formula depends on macOS needs response Needs a response from the issue/PR author outdated PR was locked due to age swift Swift use is a significant feature of the PR or issue upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sashkab @lotyp @SMillerDev @Mayurifag @fxcoudert @iMichka @chenrui333 @branchvincent @BrewTestBot @cho-m