Development #83
Merged
Development #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manifest updates
Bump version number on about page, and update description in `package.json`
…onic fro 12 word bip39 seed generation
…onic for 12 word bip39 seed generation
…mobile into bip39_zencashjs
…onic for 12 word bip39 seed generation
…onic for 12 word bip39 seed generation
BrandExpansion! And Cordova Updates.
Bip39 zencashjs
Staticfee comment cleanup
vherus
suggested changes
Feb 27, 2019
| insightAPI: 'https://explorer.zensystem.io/insight-api-zen/', | ||
| explorerURL: 'https://explorer.zensystem.io/', | ||
| insightAPI: 'https://explorer.horizen.global/api/', | ||
| explorerURL: 'https://explorer.horizen.global/', |
There was a problem hiding this comment.
I can see this URL dotted around in different places as a hard string, it would be much better moved to a constant like LANG_ENGLISH and CURRENCY_USD so we only need to update it in one place if it changes again
| </ListItem> | ||
| <ListItem tappable onClick={() => this.props.setInsightAPI('http://explorer.zenmine.pro/insight-api-zen/')}> | ||
| zenmine.pro | ||
| <ListItem tappable onClick={() => this.props.setInsightAPI('https://explorer.horizen.global/api/')}> |
There was a problem hiding this comment.
Replace with constant as detailed below
vherus
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental Update, explorer urls, zencashjs update to 1.2.0 and bip39 seed generation update to generate 12 word seeds.
Various comment cleanups.