Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add all used gazebo model files into repository so we don't need to f… #97

Merged
merged 3 commits into from
Nov 2, 2019

Conversation

le-horizon
Copy link
Contributor

…etch them from gazebosim.org, and we can maintain stability of these models.

These are all the models I can find from the current repo.
We probably need to check it every time we add a new model to SocialRobot.

Thanks,
Le

…etch them from gazebosim.org, and we can maintain stability of these models.
Copy link
Contributor

@emailweixu emailweixu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some description about the source of these files
Add make sure to we follow the license requirement: https://bitbucket.org/osrf/gazebo_models/src/default/LICENSE

Is it possible to disable downloading from the internet?

@le-horizon
Copy link
Contributor Author

Please add some description about the source of these files
Add make sure to we follow the license requirement: https://bitbucket.org/osrf/gazebo_models/src/default/LICENSE

Is it possible to disable downloading from the internet?

Good points as always @emailweixu. Done both. PTAL?

Thanks,
Le

@@ -1,13 +1,26 @@
<?xml version='1.0'?>
<database>
<name>Models used by SocialBot</name>
<name>Models used by SocialBot, copied or adapted from https://bitbucket.org/osrf/gazebo_models</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not all of them are from https://bitbucket.org/osrf/gazebo_models.
ball, texture_ground_plane, cartpole are created by us
pr2 and youbot_noplugin are from somewhere else

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr2 and yobot are also copied from there... iCub is from https://github.com/robotology/icub-gazebo

@Jialn
Copy link
Contributor

Jialn commented Nov 2, 2019

Thanks for the work. It's more convient now. There's problem download these models in mainland China I have to copy model file by hand everytime setup the running environment.

@le-horizon
Copy link
Contributor Author

Glad to know it's helpful, Jiangtao. I updated the comments, let me know if you want to make any changes to where the model files are from.

Thanks,
Le

@le-horizon le-horizon merged commit 9c0cf3a into master Nov 2, 2019
@Jialn Jialn deleted the PR_gz_models branch November 4, 2019 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants