Javascript methods like flatmap and flat are not supported

[sombhattacharyya1983]

How do we get the support for enhanced javascript functions like flatmap , flat added to html unit ?

[rbri]

This simplest way to get this is to make a pull request for rhino (https://github.com/mozilla/rhino) that adds support for this.

Second option is to motivate me to add the implementation :-); but keep in mind i'm doing all the work on HtmlUnit/Rhino in my spare time and i have a real job and a real family.

[sombhattacharyya1983]

Ok I will try and add the support in my spare time. Any guides to get started on that will be very helpful.

[rbri]

Sounds great, Rhino is a monster but adding this functions might be not that tricky.

You might start by lucking at these commits:

• mozilla/rhino@2d89acb
• mozilla/rhino@833133c
  to get a first idea how to add new functions to a class (prototype).

And regarding the implementation of flatmap and flat you might find many hints inside the existing functions like map().

And finally you have to add testcases for your new implementations. There might be something like

• mozilla/rhino@af30e13 a good starting point.

The rest is the usual game- provide your PR for Rhino and someone will jump in and add some comments.

[bhattacharyyasom]

Cool. I will do this work from this personal account. Thanks. If i need help where do I ask?

[rbri]

Am 31. Dezember 2019 19:16:46 MEZ schrieb Som Shankar Bhattacharyya <notifications@github.com>:

Cool. I will do this work from this personal account. Thanks. If i need help where do I ask? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #113 (comment)

Great, please open an issue for Rhino - if you need some help we can use the issue for discussing.

[rbri]

Looks like there are already testcases for these functions (currently disabled) in rhino.

[bhattacharyyasom]

Awesome ! Thanks for checking up on that. I will get cracking the moment I return from vacation.