Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #51

Closed
wants to merge 1 commit into from
Closed

Update README.md #51

wants to merge 1 commit into from

Conversation

posix4e
Copy link
Contributor

@posix4e posix4e commented Mar 9, 2024

Type

enhancement, documentation


Description

  • Added a command in the Procfile to start the server, optimizing the deployment process on platforms like Heroku.
  • Enhanced the README.md by adding and reorganizing badges for Playwright Tests, Unit Tests, Lint, and Vercel Deployment Status. Also, provided a direct link for deployment on Vercel, improving the project's documentation and visibility.

Changes walkthrough

Relevant files
Configuration changes
Procfile
Add Server Start Command to Procfile                                         

Procfile

  • Added a command to start the server in the Procfile.
+1/-0     
Documentation
README.md
Enhance README with CI/CD and Deployment Badges                   

README.md

  • Added badges for Playwright Tests, Unit Tests, Lint, and Vercel
    Deployment Status.
  • Provided a direct link for Vercel deployment.
  • Reorganized the badges and links for better readability.
  • +8/-4     

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    vercel bot commented Mar 9, 2024

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Comments Updated (UTC)
    mr-market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2024 6:25pm
    mr-market-back ✅ Ready (Inspect) Visit Preview Mar 9, 2024 6:25pm

    @github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 9, 2024
    Copy link

    github-actions bot commented Mar 9, 2024

    PR Description updated to latest commit (a3cadbf)

    Copy link

    github-actions bot commented Mar 9, 2024

    PR Review

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are mostly related to documentation and a simple command addition in the Procfile. The complexity and size of the changes are minimal, making it easier to review.

    🧪 Relevant tests

    No

    🔍 Possible issues

    Duplicate Badge: The "Unit Tests" badge is added twice with different workflow paths. This might confuse readers about the status of unit tests.

    🔒 Security concerns

    No

    Code feedback:
    relevant fileREADME.md
    suggestion      

    Consider merging the two "Unit Tests" badges into one or clarifying the difference between them if they cover different aspects of the unit testing. This will improve readability and avoid confusion. [important]

    relevant line![Unit Tests

    relevant fileProcfile
    suggestion      

    Ensure that the yarn and yarn run commands are followed by specific scripts to avoid ambiguity. For example, yarn install for installing dependencies and yarn start for starting the server. This clarification will make the deployment process more robust. [important]

    relevant lineweb: cd server && yarn && yarn run


    ✨ Review tool usage guide:

    Overview:
    The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
    When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

    /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
    

    With a configuration file, use the following template:

    [pr_reviewer]
    some_config1=...
    some_config2=...
    
    Utilizing extra instructions

    The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.

    Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.

    Examples for extra instructions:

    [pr_reviewer] # /review #
    extra_instructions="""
    In the 'possible issues' section, emphasize the following:
    - Does the code logic cover relevant edge cases?
    - Is the code logic clear and easy to understand?
    - Is the code logic efficient?
    ...
    """
    

    Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

    How to enable\disable automation
    • When you first install PR-Agent app, the default mode for the review tool is:
    pr_commands = ["/review", ...]
    

    meaning the review tool will run automatically on every PR, with the default configuration.
    Edit this field to enable/disable the tool, or to change the used configurations

    Auto-labels

    The review tool can auto-generate two specific types of labels for a PR:

    • a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
    • a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)
    Extra sub-tools

    The review tool provides a collection of possible feedbacks about a PR.
    It is recommended to review the possible options, and choose the ones relevant for your use case.
    Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
    require_score_review, require_soc2_ticket, and more.

    Auto-approve PRs

    By invoking:

    /review auto_approve
    

    The tool will automatically approve the PR, and add a comment with the approval.

    To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:

    [pr_reviewer]
    enable_auto_approval = true
    

    (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)

    You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:

    [pr_reviewer]
    maximal_review_effort = 5
    
    More PR-Agent commands

    To invoke the PR-Agent, add a comment using one of the following commands:

    • /review: Request a review of your Pull Request.
    • /describe: Update the PR title and description based on the contents of the PR.
    • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
    • /ask <QUESTION>: Ask a question about the PR.
    • /update_changelog: Update the changelog based on the PR's contents.
    • /add_docs 💎: Generate docstring for new components introduced in the PR.
    • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
    • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

    See the tools guide for more details.
    To list the possible configuration parameters, add a /config comment.

    See the review usage page for a comprehensive guide on using this tool.

    Copy link

    github-actions bot commented Mar 9, 2024

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Best practice
    Separate installation/build steps from the run command in the Procfile.

    It's generally a good practice to separate the installation and build steps from the run
    command in your Procfile. This ensures that your application doesn't reinstall
    dependencies every time it restarts, leading to faster startup times and more efficient
    resource use. Consider using a CI/CD pipeline to handle dependency installation and build
    steps, and modify the Procfile to only include the command to start the application.

    Procfile [1]

    -web: cd server && yarn && yarn run
    +web: cd server && yarn start
     
    Enhancement
    Rename duplicated "Unit Tests" badges for clarity.

    The badges for "Unit Tests" are duplicated with different workflow files. This might
    confuse readers about the status of unit tests in your project. If these badges represent
    different sets of tests (e.g., server-side and client-side), consider renaming them to
    reflect what they specifically represent, such as "Server Unit Tests" and "Client Unit
    Tests".

    README.md [4-5]

    -![Unit Tests](https://github.com/Hu-Fi/Mr.Market/actions/workflows/vitest.yml/badge.svg)
    -![Unit Tests](https://github.com/Hu-Fi/Mr.Market/actions/workflows/servertests.yml/badge.svg)
    +![Server Unit Tests](https://github.com/Hu-Fi/Mr.Market/actions/workflows/servertests.yml/badge.svg)
    +![Client Unit Tests](https://github.com/Hu-Fi/Mr.Market/actions/workflows/vitest.yml/badge.svg)
     

    ✨ Improve tool usage guide:

    Overview:
    The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
    When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

    /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...
    

    With a configuration file, use the following template:

    [pr_code_suggestions]
    some_config1=...
    some_config2=...
    
    Enabling\disabling automation

    When you first install the app, the default mode for the improve tool is:

    pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...]
    

    meaning the improve tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.

    Utilizing extra instructions

    Extra instructions are very important for the improve tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project.

    Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on.

    Examples for extra instructions:

    [pr_code_suggestions] # /improve #
    extra_instructions="""
    Emphasize the following aspects:
    - Does the code logic cover relevant edge cases?
    - Is the code logic clear and easy to understand?
    - Is the code logic efficient?
    ...
    """
    

    Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

    A note on code suggestions quality
    • While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically.
    • Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base.
    • Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the custom suggestions 💎 tool
    • With large PRs, best quality will be obtained by using 'improve --extended' mode.
    More PR-Agent commands

    To invoke the PR-Agent, add a comment using one of the following commands:

    • /review: Request a review of your Pull Request.
    • /describe: Update the PR title and description based on the contents of the PR.
    • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
    • /ask <QUESTION>: Ask a question about the PR.
    • /update_changelog: Update the changelog based on the PR's contents.
    • /add_docs 💎: Generate docstring for new components introduced in the PR.
    • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
    • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

    See the tools guide for more details.
    To list the possible configuration parameters, add a /config comment.

    See the improve usage page for a more comprehensive guide on using this tool.

    @posix4e posix4e temporarily deployed to mr-market-heroku-kkrczmy4bwi0w March 9, 2024 18:26 Inactive
    @posix4e posix4e closed this Mar 9, 2024
    @posix4e posix4e deleted the heroku branch March 9, 2024 18:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant