Skip to content

chore: FIT-723: Investigate intermittent test failure #8470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 2, 2025
Merged

chore: FIT-723: Investigate intermittent test failure #8470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5918230
chore: FIT-723: Investigate intermittent test failure
yyassi-heartex Sep 17, 2025
5a7873b
cleaning up change
yyassi-heartex Sep 17, 2025
1bb566f
Merge remote-tracking branch 'origin/develop' into fb-fit-723/test-fa…
yyassi-heartex Sep 17, 2025
b1c5f80
Merge remote-tracking branch 'origin/develop' into fb-fit-723/test-fa…
yyassi-heartex Sep 17, 2025
b4b0f3c
adding the @flakey tag and setting ci to skip flakey tests
yyassi-heartex Sep 17, 2025
e04de10
Merge remote-tracking branch 'origin/develop' into fb-fit-723/test-fa…
yyassi-heartex Sep 18, 2025
7301f94
adding flakey specific test
yyassi-heartex Sep 18, 2025
c948f3c
Merge branch 'develop' into fb-fit-723/test-failure
yyassi-heartex Oct 1, 2025
4a739ae
adding more flakey tests
yyassi-heartex Oct 1, 2025
20b5445
Sync Follow Merge dependencies
yyassi-heartex Oct 1, 2025
2d5cbdd
Merge branch 'develop' into fb-fit-723/test-failure
yyassi-heartex Oct 2, 2025
b190d00
Merge branch 'fb-fit-723/test-failure' of github.com:heartexlabs/labe…
yyassi-heartex Oct 2, 2025
3f2548e
while flagging flakey tests. we now retry 3 times before failing. als…
yyassi-heartex Oct 2, 2025
b233af8
linting
yyassi-heartex Oct 2, 2025
e2537a4
one more flakey test
yyassi-heartex Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions web/libs/editor/tests/e2e/tests/audio/audio-regions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ FFlagMatrix(["fflag_feat_front_lsdv_e_278_contextual_scrolling_short"], (flags)
AtOutliner.seeSelectedRegion();
AtAudioView.clickAt(220);
AtOutliner.dontSeeSelectedRegion();
});
})
.tag("@flakey")
.retry(3);

// Don't need to test this for both scenarios of flags, as it is the same code and is verified in the above test
if (!flags.fflag_feat_front_lsdv_e_278_contextual_scrolling_short) {
Expand Down Expand Up @@ -151,7 +153,9 @@ FFlagMatrix(["fflag_feat_front_lsdv_e_278_contextual_scrolling_short"], (flags)

AtOutliner.dontSeeSelectedRegion();
},
);
)
.tag("@flakey")
.retry(3);

FFlagScenario("Can select a region below a hidden region", async ({ I, LabelStudio, AtAudioView, AtOutliner }) => {
LabelStudio.setFeatureFlags({
Expand Down Expand Up @@ -189,7 +193,9 @@ FFlagMatrix(["fflag_feat_front_lsdv_e_278_contextual_scrolling_short"], (flags)
// click on the region below the hidden one to select it
AtAudioView.clickAt(51);
AtOutliner.seeSelectedRegion("Speech");
});
})
.tag("@flakey")
.retry(3);

FFlagScenario(
"Selecting a region brings it to the front of the stack",
Expand Down
4 changes: 3 additions & 1 deletion web/libs/editor/tests/e2e/tests/regression-tests/video-timeline-seek-indicator.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,6 @@ Scenario("Seek view should be in sync with indicator position", async ({ I, Labe
I.say("Seeker should now have moved to the left");
assert.ok(indicatorBbox.x < indicatorPosX, "Seeker should have moved to the left from this one step movement");
}
});
})
.tag("@flakey")
.retry(3);
4 changes: 3 additions & 1 deletion web/libs/editor/tests/e2e/tests/sync/multiple-audio.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ Scenario("Play/pause of multiple synced audio stay in sync", async ({ I, LabelSt
assert.notEqual(audioTime1, 0);
assert.notEqual(audioTime2, 0);
}
});
})
.tag("@flakey")
.retry(3);

/**
* @TODO: Fix `The play() request was interrupted by a call to pause()`
Expand Down
1 change: 1 addition & 0 deletions web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"lsf:e2e:slow": "DEFAULT_CPU_THROTTLING=100 yarn lsf:e2e",
"lsf:e2e:parallel": "cd libs/editor/tests/e2e && yarn test:parallel",
"lsf:e2e:ci": "cd libs/editor/tests/e2e && yarn test:ci",
"lsf:e2e:flakey": "cd libs/editor/tests/e2e && yarn test:ci --grep \"@flakey\"",
"lsf:integration": "nx run editor:integration",
"lsf:integration:slow": "DEFAULT_CPU_THROTTLING=4 DEFAULT_NETWORK_THROTTLING=4g nx run editor:integration",
"lsf:integration:watch": "nx run editor:integration --watch",
Expand Down
Loading