archive页面判定从title修改为单独变量 #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
archive页面有基于tag进行筛选的功能，这个js的生效取决于页面的title=Archive
title是用户自定义的，随时会进行修改，修改后就会导致tag筛选相关的js代码失效，采用这种自定义值作为一个feature的启用条件显然不是很合适。
这个pr做了调整，引入了新的变量，默认archive页面会通过is-archive=true来标记，从而保证相关feature的启用，并和自定义的title逻辑剥离