change to using functional interfaces for clientbound packet handling #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to switch the current
ClientboundPacketHandler
system to using type-safe functional interfaces instead, which are specified for each packet type individually.Motivations
registerHandler(ClientboundPartyInfoPacket.class, packet -> partyCallback(packet))
ClientboundPacketHandler
interface, which could become bothersome in the future. Each packet class also had more boilerplate which has been removed as a result.handle
method from running when it does not need to (for example, invoking a handler which does not have any implementation foronClientHelloPacket
) which aids performance (minorly)I am, as always, open to feedback on this change. I think it is overall very good in terms of the future extensibility and cleanliness of using the API.