Skip to content

Conversation

xxDark
Copy link
Contributor

@xxDark xxDark commented Apr 11, 2024

Split packet types into serverbound and clientbound packets. Add handle method to add clientbound packets.

@Amejonah1200
Copy link

Amejonah1200 commented Apr 11, 2024

... commonly known as "visitor pattern".

@xxDark xxDark marked this pull request as draft April 11, 2024 20:00
@xxDark xxDark marked this pull request as ready for review April 11, 2024 20:20
@xxDark xxDark changed the title Unify packet handling Decouple packet types Apr 11, 2024
@Janmm14
Copy link
Contributor

Janmm14 commented Apr 11, 2024

The removal of the unneeded read/write methods might not be in the interest of hypixel, they do need it

@xxDark
Copy link
Contributor Author

xxDark commented Apr 11, 2024

The removal of the unneeded method might not be in the interest of hypixel, they do need it

Which one exactly?
Edit: write methods, I guess?
Right.

# Conflicts:
#	src/main/java/net/hypixel/modapi/HypixelModAPI.java
#	src/main/java/net/hypixel/modapi/packet/HypixelPacketType.java
#	src/main/java/net/hypixel/modapi/packet/impl/clientbound/ClientboundLocationPacket.java
#	src/main/java/net/hypixel/modapi/packet/impl/clientbound/ClientboundPartyInfoPacket.java
#	src/main/java/net/hypixel/modapi/packet/impl/clientbound/ClientboundPingPacket.java
#	src/main/java/net/hypixel/modapi/packet/impl/clientbound/ClientboundPlayerInfoPacket.java
@ConnorLinfoot ConnorLinfoot merged commit 5d0b068 into HypixelDev:master Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants