Skip to content

add 'cmp=true' to every element in the CMP #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 7, 2018
Merged

add 'cmp=true' to every element in the CMP #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2d432c
add 'cmp=true' to every element in the CMP so our selectors don't hit…
Jun 7, 2018
476db6d
Revert "add 'cmp=true' to every element in the CMP so our selectors d…
braizhas Jun 7, 2018
fce0495
apply css only for child elements
braizhas Jun 7, 2018
5214b6d
some visual feedback
braizhas Jun 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/app.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,10 @@ export default class App extends Component {

updateCSSPrefs = () => {
const elems = this.elementsWithReplaceableCss;
const base = this.base;
for(let elem in elems) {
let cssRules = elems[elem];
let selectedEls = document.querySelectorAll(elem) || [];
let selectedEls = base.querySelectorAll(elem) || [];
selectedEls.forEach(function(currentEl) {
for(let cssProp in cssRules) {
currentEl.style[cssProp] = cssRules[cssProp];
Expand Down
2 changes: 1 addition & 1 deletion src/components/app.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('App', () => {
/>, scratch);

expect(app.props.config.css['font-family']).to.equal('MonoType');
expect(scratch.style['font-family']).to.equal('MonoType');
expect(scratch.style['font-family']).to.not.equal('MonoType');
expect(scratch.innerHTML).to.contain('style="font-family: MonoType;"');
});
});
2 changes: 2 additions & 0 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,7 @@
</script>
</head>
<body>
<a href="#">Some Link</a>
<div><p>Some Text</p></div>
</body>
</html>