Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groundwork for removing the vocabulary notices. #135

Closed
wants to merge 6 commits into from
Closed

Groundwork for removing the vocabulary notices. #135

wants to merge 6 commits into from

Conversation

andylolz
Copy link
Contributor

@andylolz andylolz commented Jul 20, 2018 •
edited
Loading

Refs IATI/IATI-Dashboard#174.

This notice appears in various places on the dashboard:

screen shot 2018-07-24 at 11 51 26

Rather than showing a notice saying there may be a bug, we can instead fix the bug, by adding the relevant condition to the xpath expression.

@coveralls
Copy link

coveralls commented Jul 20, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 40.869% when pulling a8cf9a5 on andylolz:174-codelist-conditions into ecc2398 on IATI:master.

@andylolz
Copy link
Contributor Author

There are several commits here, but the important one is 189ffc1.

@andylolz andylolz mentioned this pull request Jul 24, 2018
Closed
@andylolz andylolz mentioned this pull request Nov 21, 2018
Open
@andylolz andylolz closed this Nov 25, 2019
@andylolz andylolz deleted the 174-codelist-conditions branch November 25, 2019 15:49
@andylolz andylolz restored the 174-codelist-conditions branch March 25, 2021 16:43
@andylolz andylolz deleted the 174-codelist-conditions branch March 25, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andylolz @coveralls @samuele-mattiuzzo